Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 191973002: Do not suggest all_webkit to users. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 return self._build_path(binary_name) 241 return self._build_path(binary_name)
242 242
243 def _path_to_wdiff(self): 243 def _path_to_wdiff(self):
244 return self.path_from_chromium_base('third_party', 'cygwin', 'bin', 'wdi ff.exe') 244 return self.path_from_chromium_base('third_party', 'cygwin', 'bin', 'wdi ff.exe')
245 245
246 def _check_crash_service_available(self): 246 def _check_crash_service_available(self):
247 """Checks whether the crash service binary is present.""" 247 """Checks whether the crash service binary is present."""
248 result = self._check_file_exists(self._path_to_crash_service(), "content _shell_crash_service.exe") 248 result = self._check_file_exists(self._path_to_crash_service(), "content _shell_crash_service.exe")
249 if not result: 249 if not result:
250 _log.error(" Could not find crash service, unexpected crashes won 't be symbolized.") 250 _log.error(" Could not find crash service, unexpected crashes won 't be symbolized.")
251 _log.error(' Did you build the target all_webkit?') 251 _log.error(' Did you build the target blink_tests?')
252 _log.error('') 252 _log.error('')
253 return result 253 return result
254 254
255 def look_for_new_crash_logs(self, crashed_processes, start_time): 255 def look_for_new_crash_logs(self, crashed_processes, start_time):
256 if self.get_option('disable_breakpad'): 256 if self.get_option('disable_breakpad'):
257 return None 257 return None
258 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time) 258 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time)
259 259
260 def clobber_old_port_specific_results(self): 260 def clobber_old_port_specific_results(self):
261 if not self.get_option('disable_breakpad'): 261 if not self.get_option('disable_breakpad'):
262 self._dump_reader.clobber_old_results() 262 self._dump_reader.clobber_old_results()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698