Omnibox: Change |inline_autocomplete_offset| to |inline_autocompletion|

chrome/browser/ui/omnibox/omnibox_edit_model.h

Index: chrome/browser/ui/omnibox/omnibox_edit_model.h
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.h b/chrome/browser/ui/omnibox/omnibox_edit_model.h
index 4dff4ef94972c3e1b15071a3b09074c5c0095a08..af71dd45aeb703a903c0fe22bffbf989afff3896 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.h
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.h
@@ -270,7 +270,7 @@ class OmniboxEditModel {
   //     or the currently selected keyword if |is_keyword_hint| is false (see
   //     comments on keyword_ and is_keyword_hint_).
   void OnPopupDataChanged(
-      const string16& text,
+      const string16 text,

[Peter Kasting, 2013/07/16 18:09:05]

Removing the '&' here seems like a mistake

[Mark P, 2013/07/16 18:53:23]

This is critical.  If the & is there, it doesn't work.  It took me two hours to
debug this and figure out the & is the cause.

We pass match.inline_autocompletion into this function as |text|.  This function
resets match, which means it clears match.inline_autocompletion.  Hence,
everywhere later in the function that refers to |text| sees an empty string.

[Peter Kasting, 2013/07/16 18:59:55]

Hmm.  In that case perhaps the affected caller(s) should copy the string before
calling the function, with a comment about why they're doing it.

I mean, there need to be comments regardless, but it's more efficient and
perhaps more clear to do this explicitly at the caller side in the affected
places rather than implicitly in the function call itself.

[Mark P, 2013/07/16 19:47:12]

Are you sure you want me to do this?  It requires putting the ugly "make a copy"
code and comment at the location of three separate callers.

Wouldn't it be easier to add a comment here?
// We cannot take |text| or |keyword| as references because callers tends to get
these values from the current match and OnPopupDataChanged() resets the current
match.  If OnPopupDataChanged() took them as references, it would lose knowledge
of their original values.

       GURL* destination_for_temporary_text_change,
       const string16& keyword,
       bool is_keyword_hint);