chrome/browser/autocomplete/keyword_provider.cc - Issue 19197005: Omnibox: Change |inline_autocomplete_offset| to |inline_autocompletion|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/keyword_provider.cc

Issue 19197005: Omnibox: Change |inline_autocomplete_offset| to |inline_autocompletion| (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix issue with using a reference in a place we shouldn't Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/history_url_provider.cc ('K') | « chrome/browser/autocomplete/history_url_provider_unittest.cc ('k') | chrome/browser/autocomplete/search_provider.cc » ('j') | chrome/browser/autocomplete/search_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/keyword_provider.cc

diff --git a/chrome/browser/autocomplete/keyword_provider.cc b/chrome/browser/autocomplete/keyword_provider.cc

index 10ae975c95dd33633a927adeee460f7faa4e74a4..2a6c8a6c0aaa40aed5e09dd9c3c77931faf3730b 100644

--- a/chrome/browser/autocomplete/keyword_provider.cc

+++ b/chrome/browser/autocomplete/keyword_provider.cc

@@ -446,12 +446,6 @@ AutocompleteMatch KeywordProvider::CreateAutocompleteMatch(

if (!remaining_input.empty() || !keyword_complete || supports_replacement)

match.fill_into_edit.push_back(L' ');

match.fill_into_edit.append(remaining_input);

- // If we wanted to set |result.inline_autocomplete_offset| correctly, we'd

- // need CleanUserInputKeyword() to return the amount of adjustment it's made

- // to the user's input. Because right now inexact keyword matches can't score

- // more highly than a "what you typed" match from one of the other providers,

- // we just don't bother to do this, and leave inline autocompletion off.

Peter Kasting 2013/07/16 18:09:05 We should perhaps preserve the comment here about

Mark P 2013/07/16 18:53:23 Okay.

- match.inline_autocomplete_offset = string16::npos;

// Create destination URL and popup entry content by substituting user input

// into keyword templates.