Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/browser/autocomplete/autocomplete_match.h

Issue 19197005: Omnibox: Change |inline_autocomplete_offset| to |inline_autocompletion| (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix issue with using a reference in a place we shouldn't Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_match.h
diff --git a/chrome/browser/autocomplete/autocomplete_match.h b/chrome/browser/autocomplete/autocomplete_match.h
index 4d4ca47c363849ff42a5b2d4b409c9b2fefff693..586c4a25a01e46c7fff4b191d88b9c3b9e069798 100644
--- a/chrome/browser/autocomplete/autocomplete_match.h
+++ b/chrome/browser/autocomplete/autocomplete_match.h
@@ -246,10 +246,9 @@ struct AutocompleteMatch {
// for search suggestions, this would just be the search terms.
string16 fill_into_edit;
- // The position within fill_into_edit from which we'll display the inline
- // autocomplete string. This will be string16::npos if this match should
- // not be inline autocompleted.
- size_t inline_autocomplete_offset;
+ // The text to display as a blue highlight selection after the cursor,
+ // if this match is displayed inline (i.e., within the omnibox).
Peter Kasting 2013/07/16 18:09:05 Nit: Don't refer to "blue", that's a Windows-ism.
Mark P 2013/07/16 18:53:23 Okay. Done.
+ string16 inline_autocompletion;
// The URL to actually load when the autocomplete item is selected. This URL
// should be canonical so we can compare URLs with strcmp to avoid dupes.

Powered by Google App Engine
This is Rietveld 408576698