Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chrome/browser/autocomplete/history_quick_provider_unittest.cc

Issue 19197005: Omnibox: Change |inline_autocomplete_offset| to |inline_autocompletion| (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: drop user_text() in omnibox_edit_model Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_quick_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/history_quick_provider_unittest.cc b/chrome/browser/autocomplete/history_quick_provider_unittest.cc
index e1c805e04bd054b14539e4d05f9270905f8d9d06..9c14157632cc76772895c8abe8e44461802297a7 100644
--- a/chrome/browser/autocomplete/history_quick_provider_unittest.cc
+++ b/chrome/browser/autocomplete/history_quick_provider_unittest.cc
@@ -295,11 +295,11 @@ void HistoryQuickProviderTest::RunTest(const string16 text,
<< "' but we expected '" << expected_fill_into_edit << "'.";
size_t text_pos = expected_fill_into_edit.find(text);
ASSERT_NE(string16::npos, text_pos);
- EXPECT_EQ(text_pos + text.size(),
- ac_matches_[0].inline_autocomplete_offset);
+ EXPECT_EQ(ac_matches_[0].fill_into_edit.substr(text_pos + text.size()),
+ ac_matches_[0].inline_autocompletion);
} else {
// When the top scorer is not inline-able autocomplete offset must be npos.
- EXPECT_EQ(string16::npos, ac_matches_[0].inline_autocomplete_offset);
+ EXPECT_TRUE(ac_matches_[0].inline_autocompletion.empty());
// Also, the score must be too low to be inlineable.
EXPECT_LT(ac_matches_[0].relevance,
AutocompleteResult::kLowestDefaultScore);
« no previous file with comments | « chrome/browser/autocomplete/history_quick_provider.cc ('k') | chrome/browser/autocomplete/history_url_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698