Change LineWidth::snapUncommittedWidth to ceil

Change LineWidth::snapUncommittedWidth to ceil

Change the snapUncommittedWidth method on the LineWidth class to ceil to
the nearest LayoutUnit rather than to floor. It's only called from a one
place, BreakingContext::increment, where the intent is to increment, not
decrement, the uncommitted width. This ensures that the snapped width is
wide enough to contain the text.

This fixes a bug where tabulation characters were omitted incorrectly in
text layout due to the width being floored during the width commit step.

R=kojii@chromium.org
BUG=605820
Committed: https://crrev.com/957ee1cf9558f59e65c943a85fab2ec7ce94ebe2
Cr-Commit-Position: refs/heads/master@{#389413}

[eae, 2016-04-25 02:18:05]

Description was changed from

==========
ceil to layout unit when clamping in line width

BUG=605820
==========

to

==========
Change LineWidth::snapUncommittedWidth to ceil

Change the snapUncommittedWidth method on the LineWidth class to ceil to
the nearest LayoutUnit rather than to floor. It's only called from a one
place, BreakingContext::increment, where the intent is to increment, not
decrement, the uncommitted width. This ensures that the snapped width is
wide enough to contain the text.

This fixes a bug where tabulation characters were omitted incorrectly in
text layout due to the width being floored during the width commit step. 

R=kojii@chromium.org
BUG=605820
==========

[eae, 2016-04-25 02:18:06]

eae@chromium.org changed reviewers:
+ kojii@chromium.org

[kojii, 2016-04-25 04:18:58]

lgtm

[eae, 2016-04-25 04:19:34]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-04-25 04:19:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919693002/1

[commit-bot: I haz the power, 2016-04-25 04:59:09]

Description was changed from

==========
Change LineWidth::snapUncommittedWidth to ceil

Change the snapUncommittedWidth method on the LineWidth class to ceil to
the nearest LayoutUnit rather than to floor. It's only called from a one
place, BreakingContext::increment, where the intent is to increment, not
decrement, the uncommitted width. This ensures that the snapped width is
wide enough to contain the text.

This fixes a bug where tabulation characters were omitted incorrectly in
text layout due to the width being floored during the width commit step. 

R=kojii@chromium.org
BUG=605820
==========

to

==========
Change LineWidth::snapUncommittedWidth to ceil

Change the snapUncommittedWidth method on the LineWidth class to ceil to
the nearest LayoutUnit rather than to floor. It's only called from a one
place, BreakingContext::increment, where the intent is to increment, not
decrement, the uncommitted width. This ensures that the snapped width is
wide enough to contain the text.

This fixes a bug where tabulation characters were omitted incorrectly in
text layout due to the width being floored during the width commit step. 

R=kojii@chromium.org
BUG=605820
==========

[commit-bot: I haz the power, 2016-04-25 04:59:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-25 05:00:19]

Description was changed from

==========
Change LineWidth::snapUncommittedWidth to ceil

Change the snapUncommittedWidth method on the LineWidth class to ceil to
the nearest LayoutUnit rather than to floor. It's only called from a one
place, BreakingContext::increment, where the intent is to increment, not
decrement, the uncommitted width. This ensures that the snapped width is
wide enough to contain the text.

This fixes a bug where tabulation characters were omitted incorrectly in
text layout due to the width being floored during the width commit step. 

R=kojii@chromium.org
BUG=605820
==========

to

==========
Change LineWidth::snapUncommittedWidth to ceil

Change the snapUncommittedWidth method on the LineWidth class to ceil to
the nearest LayoutUnit rather than to floor. It's only called from a one
place, BreakingContext::increment, where the intent is to increment, not
decrement, the uncommitted width. This ensures that the snapped width is
wide enough to contain the text.

This fixes a bug where tabulation characters were omitted incorrectly in
text layout due to the width being floored during the width commit step.

R=kojii@chromium.org
BUG=605820

Committed: https://crrev.com/957ee1cf9558f59e65c943a85fab2ec7ce94ebe2
Cr-Commit-Position: refs/heads/master@{#389413}
==========

[commit-bot: I haz the power, 2016-04-25 05:00:20]

Patchset 1 (id:??) landed as
https://crrev.com/957ee1cf9558f59e65c943a85fab2ec7ce94ebe2
Cr-Commit-Position: refs/heads/master@{#389413}

[szager1, 2016-04-25 19:06:59]

szager@chromium.org changed reviewers:
+ szager@chromium.org

[szager1, 2016-04-25 19:06:59]

Thanks for tracking this down!