Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1919673006:
Prevent unnecessary memory (de-)allocations in LiteralBuffer::CopyFrom. (Closed)
DescriptionPrevent unnecessary memory (de-)allocations in LiteralBuffer::CopyFrom.
BUG=v8:4947
LOG=Y
Committed: https://crrev.com/5e9b1eb3b559d22ee58b9a02fe148d6df4affaed
Cr-Commit-Position: refs/heads/master@{#35857}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== Prevent unnecessary memory (de-)allocations in LiteralBuffer::CopyFrom. BUG= ========== to ========== Prevent unnecessary memory (de-)allocations in LiteralBuffer::CopyFrom. BUG=v8:4947 ==========
vogelheim@chromium.org changed reviewers: + jochen@chromium.org
vogelheim@chromium.org changed reviewers: + rossberg@chromium.org
+rossberg, as parsing/* owner.
lgtm
adamk@chromium.org changed reviewers: + adamk@chromium.org
Excited to see a cover bug for performance work on the parser. Can you say something in the CL description about what effect this has on performance (on which benchmarks?)?
lgtm
On 2016/04/26 19:15:45, adamk wrote: > Excited to see a cover bug for performance work on the parser. Can you say > something in the CL description about what effect this has on performance (on > which benchmarks?)? The performance effect on the usual benchmarks is unremarkable. Per the perf try-bots, for Octane & Kraken, results are universally in the +/- 0.x% range. What does improve quite a bit is the (unfortunately non-public) bug report that triggered this case. Note that this is consistent w/ recent findings: That our current benchmarks have quite a few blind spots, and don't accurately represent some aspects of performance which still happens to be relevant in real-world use cases. Also, when I originally introduced the change, I did check against out benchmark suite and didn't see any performance drop across the board; so I'm not surprised if performance doesn't jump up if I fix this issue. Related to this, we're currently looking more specifically at the Parser, with better, parser-centric metrics.
The CQ bit was checked by vogelheim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919673006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919673006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14289)
Description was changed from ========== Prevent unnecessary memory (de-)allocations in LiteralBuffer::CopyFrom. BUG=v8:4947 ========== to ========== Prevent unnecessary memory (de-)allocations in LiteralBuffer::CopyFrom. BUG=v8:4947 LOG=Y ==========
The CQ bit was checked by vogelheim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919673006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919673006/1
Message was sent while issue was closed.
Description was changed from ========== Prevent unnecessary memory (de-)allocations in LiteralBuffer::CopyFrom. BUG=v8:4947 LOG=Y ========== to ========== Prevent unnecessary memory (de-)allocations in LiteralBuffer::CopyFrom. BUG=v8:4947 LOG=Y ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Prevent unnecessary memory (de-)allocations in LiteralBuffer::CopyFrom. BUG=v8:4947 LOG=Y ========== to ========== Prevent unnecessary memory (de-)allocations in LiteralBuffer::CopyFrom. BUG=v8:4947 LOG=Y Committed: https://crrev.com/5e9b1eb3b559d22ee58b9a02fe148d6df4affaed Cr-Commit-Position: refs/heads/master@{#35857} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5e9b1eb3b559d22ee58b9a02fe148d6df4affaed Cr-Commit-Position: refs/heads/master@{#35857} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
