Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1919673005:
Fix mash chrome crashing when hovering over link. (Closed)
DescriptionFix mash chrome crashing when hovering over link.
When built for ozone, mash crashes whenever the user hovers over a link
in chrome and the URL is shown in the bottom left corner. This happens
because PlatformDisplay uses an invalid blending mode for the partially
transparent quad that contains the URL. Change blending mode to not
crash.
BUG=604109
Committed: https://crrev.com/b97005f01da370fa7b59b65ce7d1eb2eca1fa205
Cr-Commit-Position: refs/heads/master@{#389512}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Fix another instance. #Messages
Total messages: 20 (9 generated)
kylechar@chromium.org changed reviewers: + sky@chromium.org
LGTM https://codereview.chromium.org/1919673005/diff/1/components/mus/ws/platform_... File components/mus/ws/platform_display.cc (left): https://codereview.chromium.org/1919673005/diff/1/components/mus/ws/platform_... components/mus/ws/platform_display.cc:121: window->opacity(), SkXfermode::kSrc_Mode, 0 /* sorting-context_id */); AHA! This must be the random CHECK I randomly see: #0 0x7f320e07e66e base::debug::StackTrace::StackTrace() #1 0x7f320e0def5f logging::LogMessage::~LogMessage() #2 0x7f320226efef cc::(anonymous namespace)::BlendModeFromSkXfermode() #3 0x7f3202267c75 cc::GLRenderer::DrawRenderPassQuad() #4 0x7f32022654f5 cc::GLRenderer::DoDrawQuad() #5 0x7f3202251935 cc::DirectRenderer::DrawRenderPass() #6 0x7f32022506e3 cc::DirectRenderer::DrawRenderPassAndExecuteCopyRequests() #7 0x7f320225058e cc::DirectRenderer::DrawFrame() #8 0x7f32010b5579 cc::Display::DrawAndSwap() #9 0x7f32010c9d72 cc::DisplayScheduler::DrawAndSwap() #10 0x7f32010c94a2 cc::DisplayScheduler::AttemptDrawAndSwap() #11 0x7f32010c8eec cc::DisplayScheduler::OnBeginFrameDeadline() #12 0x7f32010cdeb9 _ZN4base8internal15RunnableAdapterIMN2cc16DisplaySchedulerEFvvEE3RunIJEEEvPS3_DpOT_ #13 0x7f32010cddc0 _ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIMN2cc16DisplaySchedulerEFvvEEEE8MakeItSoINS_7WeakPtrIS4_EEJEEEvS7_T_DpOT0_ #14 0x7f32010cdd6d _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN2cc16DisplaySchedulerEFvvEEEFvPS7_EJNS_7WeakPtrIS7_E\ Nice!
The CQ bit was checked by kylechar@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919673005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919673005/1
https://codereview.chromium.org/1919673005/diff/1/components/mus/ws/platform_... File components/mus/ws/platform_display.cc (right): https://codereview.chromium.org/1919673005/diff/1/components/mus/ws/platform_... components/mus/ws/platform_display.cc:142: window->opacity(), SkXfermode::kSrc_Mode, 0 /* sorting-context_id */); Should this be updated too?
The CQ bit was unchecked by kylechar@chromium.org
https://codereview.chromium.org/1919673005/diff/1/components/mus/ws/platform_... File components/mus/ws/platform_display.cc (right): https://codereview.chromium.org/1919673005/diff/1/components/mus/ws/platform_... components/mus/ws/platform_display.cc:142: window->opacity(), SkXfermode::kSrc_Mode, 0 /* sorting-context_id */); On 2016/04/25 16:04:17, sky wrote: > Should this be updated too? It seems like this would cause a crash in the same way if opacity wasn't 1.0f. I'll update it as well.
The CQ bit was checked by kylechar@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/1919673005/#ps20001 (title: "Fix another instance.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919673005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919673005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was unchecked by commit-bot@chromium.org
On 2016/04/25 17:44:43, commit-bot: I haz the power wrote: > Failed to commit the patch. Well, that was weird. Going to just try it again.
The CQ bit was checked by kylechar@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919673005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919673005/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix mash chrome crashing when hovering over link. When built for ozone, mash crashes whenever the user hovers over a link in chrome and the URL is shown in the bottom left corner. This happens because PlatformDisplay uses an invalid blending mode for the partially transparent quad that contains the URL. Change blending mode to not crash. BUG=604109 ========== to ========== Fix mash chrome crashing when hovering over link. When built for ozone, mash crashes whenever the user hovers over a link in chrome and the URL is shown in the bottom left corner. This happens because PlatformDisplay uses an invalid blending mode for the partially transparent quad that contains the URL. Change blending mode to not crash. BUG=604109 Committed: https://crrev.com/b97005f01da370fa7b59b65ce7d1eb2eca1fa205 Cr-Commit-Position: refs/heads/master@{#389512} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b97005f01da370fa7b59b65ce7d1eb2eca1fa205 Cr-Commit-Position: refs/heads/master@{#389512} |
