Issue 1919653002: Revert "Make NeedsRebaseline illegal in layout_test TestExpectations for now."

Issue 1919653002: Revert "Make NeedsRebaseline illegal in layout_test TestExpectations for now." (Closed)

Created:
4 years, 8 months ago by wkorman

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, Dirk Pranke

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert "Make NeedsRebaseline illegal in layout_test TestExpectations for now." Mac 10.9 build looks stable per work in http://crbug.com/601166. Try re-enabling the auto-rebaseline bot and support for NeedsRebaseline on layout tests. This reverts commit 5f6db60551a6cd52e4c0638a1ed669eecf25af3b. BUG=603753 TBR=dpranke@chromium.org,eae@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c9fe23264fc91bfdea90cb6c990aaaa09c40e210

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -10 lines)			Patch
M	third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 7 (5 generated)

commit-bot: I haz the power

Patchset 2 (id:??) landed as https://crrev.com/c9fe23264fc91bfdea90cb6c990aaaa09c40e210 Cr-Commit-Position: refs/heads/master@{#389385}

4 years, 8 months ago (2016-04-23 20:52:25 UTC) #5

wkorman

4 years, 8 months ago (2016-04-23 20:53:21 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c9fe23264fc91bfdea90cb6c990aaaa09c40e210 (presubmit successful).