Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 1919643002: Remove RefCountedGarbageCollected<>. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, kinuko+watch, kouhei+heap_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sof-data-pers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RefCountedGarbageCollected<>. Exposing a garbage collected object as something ref-counted is no longer needed, hence the functionality can be removed. R= BUG=604481 Committed: https://crrev.com/a2f08ba571cf9fb5c190b95c793bfa0ba84ffe85 Cr-Commit-Position: refs/heads/master@{#389419}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -137 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GarbageCollected.h View 2 chunks +0 lines, -84 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 7 chunks +60 lines, -38 lines 0 comments Download
M third_party/WebKit/public/platform/WebPrivatePtr.h View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sof
please take a look (tkent@ for public/ WebPrivatePtr.h change.)
4 years, 8 months ago (2016-04-24 08:11:20 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-24 16:52:23 UTC) #5
tkent
lgtm. nit: ASSERT is deprecated in favor of DCHECK. However, ASSERTs in this CL is ...
4 years, 8 months ago (2016-04-24 22:55:39 UTC) #6
sof
On 2016/04/24 22:55:39, tkent wrote: > lgtm. > > nit: ASSERT is deprecated in favor ...
4 years, 8 months ago (2016-04-25 05:21:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919643002/20001
4 years, 8 months ago (2016-04-25 05:31:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 06:40:22 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 06:41:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2f08ba571cf9fb5c190b95c793bfa0ba84ffe85
Cr-Commit-Position: refs/heads/master@{#389419}

Powered by Google App Engine
This is Rietveld 408576698