Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 191963002: Use new Traversal<SVG*Element> API more in SVG code (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
pdr., eseidel
CC:
blink-reviews, shans, eae+blinkwatch, fs, adamk+blink_chromium.org, Steve Block, dino_apple.com, rwlbuis, krit, alancutter (OOO until 2018), dglazkov+blink, dstockwell, Timothy Loh, pdr., Eric Willigers, rjwright, sof, gyuyoung.kim_webkit.org, darktears, kouhei+svg_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney
Visibility:
Public.

Description

Use new Traversal<SVG*Element> API more in SVG code Use new Traversal<SVG*Element> API more in SVG code. This makes the code a bit shorter / simpler. This CL also defines new DEFINE_ELEMENT_TYPE_CASTS*() macros that do the same as DEFINE_NODE_TYPE_CASTS*() macros but also provide a template specialization of isElementOfType<>() so that the Traversal<> API also works for these Element types. For most types, those helpers are automatically generated from SVGTagNames.in and those require no additional work. R=eseidel, pdr BUG=346733 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -38 lines) Patch
M Source/core/dom/Element.h View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGFELightElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMergeElement.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGGradientElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPolyElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 2 chunks +4 lines, -9 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPositioningElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 3 chunks +4 lines, -7 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 9 months ago (2014-03-08 17:22:10 UTC) #1
eseidel
lgtm
6 years, 9 months ago (2014-03-08 21:27:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/191963002/1
6 years, 9 months ago (2014-03-08 21:28:00 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 22:05:39 UTC) #4
Message was sent while issue was closed.
Change committed as 168790

Powered by Google App Engine
This is Rietveld 408576698