Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1919613002: media: Fix gn deps on media/base/* targets (Closed)

Created:
4 years, 8 months ago by jrummell
Modified:
4 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn deps on media/base/* targets Add some needed dependencies. BUG=599578 Committed: https://crrev.com/c18e5fe9d86ffbea6765a5bc30860cb342ef18c5 Cr-Commit-Position: refs/heads/master@{#391363}

Patch Set 1 #

Patch Set 2 : common test file #

Patch Set 3 : rebase #

Patch Set 4 : win issue + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M media/base/BUILD.gn View 1 2 3 6 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
jrummell
PTAL. This cleans up the errors for the test/perftest/etc targets.
4 years, 8 months ago (2016-04-23 00:53:42 UTC) #2
DaleCurtis
lgtm
4 years, 8 months ago (2016-04-23 19:01:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919613002/1
4 years, 8 months ago (2016-04-25 06:36:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/84043)
4 years, 8 months ago (2016-04-25 06:52:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919613002/60001
4 years, 7 months ago (2016-05-03 21:36:14 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-03 21:42:07 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 21:44:07 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/c18e5fe9d86ffbea6765a5bc30860cb342ef18c5
Cr-Commit-Position: refs/heads/master@{#391363}

Powered by Google App Engine
This is Rietveld 408576698