chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc - Issue 1919593003: arc: Prevent showing Opt-in UI when it is not expected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc

Issue 1919593003: arc: Prevent showing Opt-in UI when it is not expected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TODO added Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc ('k') | chrome/browser/ui/ash/launcher/launcher_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc

diff --git a/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc b/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc

index cea24f8fcee2e0868dad4dda695615c22d4d005b..4614b30a78c46ce453b46ed2e900c0bea34daf91 100644

--- a/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc

+++ b/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc

@@ -83,7 +83,7 @@ void ExtensionLauncherContextMenu::Init() {

AddItemWithStringId(MENU_CLOSE, IDS_LAUNCHER_CONTEXT_MENU_CLOSE);

} else {

if (item().type == ash::TYPE_PLATFORM_APP)

- AddItemWithStringId(MENU_PIN, IDS_LAUNCHER_CONTEXT_MENU_PIN);

+ AddPinMenu();

bool show_close_button = controller()->IsOpen(item().id);

#if defined(OS_CHROMEOS)

if (extension_misc::IsImeMenuExtensionId(