xfa/fxfa/parser/xfa_utils_imp.cpp - Issue 1919563002: Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_utils_imp.cpp

Issue 1919563002: Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix issue from c4 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/parser/xfa_utils_imp.cpp

diff --git a/xfa/fxfa/parser/xfa_utils_imp.cpp b/xfa/fxfa/parser/xfa_utils_imp.cpp

index 4fec7c071b1dfe53cba96047836a2fb32190ef02..77cac00b893f386ba2f187ecf4d2e17470ccb0fb 100644

--- a/xfa/fxfa/parser/xfa_utils_imp.cpp

+++ b/xfa/fxfa/parser/xfa_utils_imp.cpp

@@ -196,8 +196,7 @@ void XFA_GetPlainTextFromRichText(CFDE_XMLNode* pXMLNode,

CFDE_XMLElement* pXMLElement = static_cast<CFDE_XMLElement*>(pXMLNode);

CFX_WideString wsTag;

pXMLElement->GetLocalTagName(wsTag);

- uint32_t uTag =

- FX_HashCode_String_GetW(wsTag.c_str(), wsTag.GetLength(), TRUE);

+ uint32_t uTag = FX_HashCode_GetW(wsTag.AsStringC(), true);

if (uTag == 0x0001f714) {

wsPlainText += L"\n";

} else if (uTag == 0x00000070) {

« no previous file with comments | « xfa/fxfa/parser/xfa_script_resolveprocessor.cpp ('k') | no next file » | no next file with comments »