xfa/fxfa/parser/xfa_script_nodehelper.cpp - Issue 1919563002: Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_script_nodehelper.cpp

Issue 1919563002: Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix issue from c4 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/parser/xfa_script_nodehelper.cpp

diff --git a/xfa/fxfa/parser/xfa_script_nodehelper.cpp b/xfa/fxfa/parser/xfa_script_nodehelper.cpp

index 96ae98aeaf89448ffca5119cb1e1395f6d14b609..96ecc5a125a9e009017379fe8bf240a84cc61ef0 100644

--- a/xfa/fxfa/parser/xfa_script_nodehelper.cpp

+++ b/xfa/fxfa/parser/xfa_script_nodehelper.cpp

@@ -33,7 +33,7 @@ CXFA_Node* CXFA_NodeHelper::XFA_ResolveNodes_GetOneChild(

return NULL;

}

CXFA_NodeArray siblings;

- uint32_t uNameHash = FX_HashCode_String_GetW(pwsName, FXSYS_wcslen(pwsName));

+ uint32_t uNameHash = FX_HashCode_GetW(CFX_WideStringC(pwsName), false);

XFA_NodeAcc_TraverseAnySiblings(parent, uNameHash, &siblings, bIsClassName);

if (siblings.GetSize() == 0) {

return NULL;

« no previous file with comments | « xfa/fxfa/parser/xfa_script_imp.cpp ('k') | xfa/fxfa/parser/xfa_script_resolveprocessor.cpp » ('j') | no next file with comments »