xfa/fxfa/parser/cxfa_widgetdata.cpp - Issue 1919563002: Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/cxfa_widgetdata.cpp

Issue 1919563002: Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix issue from c4 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/parser/cxfa_widgetdata.cpp

diff --git a/xfa/fxfa/parser/cxfa_widgetdata.cpp b/xfa/fxfa/parser/cxfa_widgetdata.cpp

index a702527347d7ba2a3d66f4e415b2baf524dc222f..0c3d065a39a2145742821335eba3b1d6b32278fd 100644

--- a/xfa/fxfa/parser/cxfa_widgetdata.cpp

+++ b/xfa/fxfa/parser/cxfa_widgetdata.cpp

@@ -466,8 +466,7 @@ CXFA_Node* CXFA_WidgetData::GetSelectedMember() {

CXFA_Node* CXFA_WidgetData::SetSelectedMember(const CFX_WideStringC& wsName,

FX_BOOL bNotify) {

CXFA_Node* pSelectedMember = NULL;

- uint32_t nameHash =

- FX_HashCode_String_GetW(wsName.c_str(), wsName.GetLength());

+ uint32_t nameHash = FX_HashCode_GetW(wsName, false);

for (CXFA_Node* pNode = ToNode(m_pNode->GetNodeItem(XFA_NODEITEM_FirstChild));

pNode; pNode = pNode->GetNodeItem(XFA_NODEITEM_NextSibling)) {

if (pNode->GetNameHash() == nameHash) {

« no previous file with comments | « xfa/fxfa/fm2js/xfa_simpleexpression.cpp ('k') | xfa/fxfa/parser/xfa_basic_imp.cpp » ('j') | no next file with comments »