fpdfsdk/javascript/global.cpp - Issue 1919563002: Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/global.cpp

Issue 1919563002: Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix issue from c4 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/javascript/global.cpp

diff --git a/fpdfsdk/javascript/global.cpp b/fpdfsdk/javascript/global.cpp

index 380713b425d79245fe0320051f926fd81ff385c0..043bd290ac7d90eb7288adff417b618662b6da34 100644

--- a/fpdfsdk/javascript/global.cpp

+++ b/fpdfsdk/javascript/global.cpp

@@ -53,7 +53,7 @@ const unsigned int JSCONST_nUndefHash =

CHash<'u', 'n', 'd', 'e', 'f', 'i', 'n', 'e', 'd'>::value;

static unsigned JS_CalcHash(const wchar_t* main) {

- return (unsigned)FX_HashCode_String_GetW(main, FXSYS_wcslen(main));

+ return (unsigned)FX_HashCode_GetW(CFX_WideStringC(main), false);

}

#ifndef NDEBUG

« no previous file with comments | « core/fxcrt/include/fx_ext.h ('k') | xfa/fde/css/fde_csscache.cpp » ('j') | no next file with comments »