xfa/fde/css/fde_cssstylesheet.h - Issue 1919563002: Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fde/css/fde_cssstylesheet.h

Issue 1919563002: Pass CFX_*StringCs to FX_HashCode_GETA and _GETW hash functions. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: win again again again Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fde/css/fde_cssstylesheet.h

diff --git a/xfa/fde/css/fde_cssstylesheet.h b/xfa/fde/css/fde_cssstylesheet.h

index 8ae8bd539313e16820b5871076be453234724904..c41bfbf520f421e3c2dda8cf8b6e07e62ad0feec 100644

--- a/xfa/fde/css/fde_cssstylesheet.h

+++ b/xfa/fde/css/fde_cssstylesheet.h

@@ -17,7 +17,7 @@ class CFDE_CSSSelector : public IFDE_CSSSelector, public CFX_Target {

int32_t iLen,

FX_BOOL bIgnoreCase)

Lei Zhang 2016/04/23 01:33:29 Also bool, 4 callers in xfa/fde/css/fde_cssstylesh

Tom Sepez 2016/04/25 16:50:20 Done.

: m_eType(eType),

- m_dwHash(FX_HashCode_String_GetW(psz, iLen, bIgnoreCase)),

+ m_dwHash(FX_HashCode_GetW(CFX_WideStringC(psz, iLen), bIgnoreCase)),

m_pNext(NULL) {}

virtual FDE_CSSSELECTORTYPE GetType() const { return m_eType; }

« no previous file with comments | « xfa/fde/css/fde_cssstyleselector.cpp ('k') | xfa/fde/css/fde_cssstylesheet.cpp » ('j') | xfa/fgas/crt/fgas_codepage.cpp » ('J')