Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1919503003: native_support service: SynchronousInterfacePtr conversion in tests. (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 8 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

native_support service: SynchronousInterfacePtr conversion in tests. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d80984bde70b10b5f5cf5efb95695d8f5d77cf40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -90 lines) Patch
M services/native_support/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M services/native_support/process_controller_impl_unittest.cc View 6 chunks +18 lines, -21 lines 0 comments Download
M services/native_support/process_impl_unittest.cc View 4 chunks +19 lines, -21 lines 0 comments Download
M services/native_support/process_test_base.h View 2 chunks +4 lines, -46 lines 0 comments Download
M services/native_support/process_test_base.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
4 years, 8 months ago (2016-04-23 00:57:16 UTC) #1
viettrungluu
ping
4 years, 8 months ago (2016-04-25 20:40:38 UTC) #2
viettrungluu
On 2016/04/25 20:40:38, viettrungluu wrote: > ping Unless you're dead/comatose/resting/not working/slacking. That's OK too. (Well, ...
4 years, 8 months ago (2016-04-25 20:52:44 UTC) #3
vardhan
lgtm
4 years, 8 months ago (2016-04-25 20:54:52 UTC) #4
viettrungluu
4 years, 8 months ago (2016-04-25 21:17:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d80984bde70b10b5f5cf5efb95695d8f5d77cf40 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698