Issue 19195003: Fix gyp_v8 to work with use_system_icu=1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19195003: Fix gyp_v8 to work with use_system_icu=1 (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix gyp_v8 to work with use_system_icu=1 If you want to use the system icu library, you'll need to use gyp_v8 (as opposed to the standalone Makefiles) BUG=v8:2475 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15677

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
M	Makefile	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Makefile.android	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Makefile.nacl	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	build/gyp_v8	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Jakob Kummerow

LGTM, but I can haz support for this in the Makefile too plz?

7 years, 5 months ago (2013-07-15 14:32:22 UTC) #2

jochen (gone - plz use gerrit)

7 years, 5 months ago (2013-07-15 15:41:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r15677 (presubmit successful).