Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1919483002: Revert of Convert cpplint.py to work with nested git repositories. (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 7 months ago
Reviewers:
iannucci, sdefresne, skym
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Convert cpplint.py to work with nested git repositories. (patchset #1 id:1 of https://codereview.chromium.org/1897153003/ ) Reason for revert: This breaks WebRTC presubmit on the buildbots (due to /b/build being a Git repo, which in turn contains the checkout). See https://bugs.chromium.org/p/webrtc/issues/detail?id=5818 for more details. It seems it also broke other projects (rakuco's comment #15). Original issue's description: > Convert cpplint.py to work with nested git repositories. > > Chrome on iOS downstream repository tracks Chromium via DEPS and wants > to use cpplint canned presubmit check but the cpplint.py errors due at > the include guard as it stops at the inner most git repository. > > Change cpplint.py to look for the outermost git repository when looking > for the repository root. > > BUG=598090 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300085 TBR=iannucci@chromium.org,skym@chromium.org,sdefresne@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=598090 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M cpplint.py View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_chromium
Created Revert of Convert cpplint.py to work with nested git repositories.
4 years, 8 months ago (2016-04-22 19:26:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919483002/1
4 years, 8 months ago (2016-04-22 19:26:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300119
4 years, 8 months ago (2016-04-22 19:29:19 UTC) #4
sdefresne
4 years, 7 months ago (2016-04-27 06:43:14 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698