Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1919473003: [ios Mojo] Added util function to convert WKSecurityOrigin to GURL. (Closed)

Created:
4 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 7 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios Mojo] Added util function to convert WKSecurityOrigin to GURL. Mojo JS API requires synchronous communication and the only way to do this is to use window.prompt. window.prompt will be used for communication *only* for app specific URLs. GURLOriginWithWKSecurityOrigin will be used inside prompt WKNavigation callback to convert WKSecurityOrigin to GURL, which will be passed to |isAppSpecificURL|. Mojo for WebUI design doc: https://docs.google.com/document/d/1iUJXX_zoY2BbnecpfxjznOeasf29KUzl_9S_LG08Bes/edit#heading=h.yjqp5garsqf9 BUG=567809 Committed: https://crrev.com/79fb44bf5c05683a19f378e85afd74c705b3ac8c Cr-Commit-Position: refs/heads/master@{#390544}

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -32 lines) Patch
M ios/chrome/browser/ssl/ios_chrome_security_state_model_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/BUILD.gn View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/ios_web.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/web/ios_web_unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/public/origin_util.h View 2 chunks +5 lines, -0 lines 0 comments Download
D ios/web/public/origin_util.cc View 1 chunk +0 lines, -28 lines 0 comments Download
A + ios/web/public/origin_util.mm View 1 2 chunks +16 lines, -1 line 0 comments Download
A ios/web/public/origin_util_unittest.mm View 1 2 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919473003/1
4 years, 8 months ago (2016-04-22 23:46:12 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/164516)
4 years, 8 months ago (2016-04-23 00:06:29 UTC) #4
Eugene But (OOO till 7-30)
This is the place where I'm going to use this utility function: https://codereview.chromium.org/1906993003/patch/60001/70043
4 years, 7 months ago (2016-04-28 21:35:04 UTC) #7
Jackie Quinn
lgtm
4 years, 7 months ago (2016-04-28 21:57:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919473003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919473003/40001
4 years, 7 months ago (2016-04-28 22:06:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/166874)
4 years, 7 months ago (2016-04-28 23:57:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919473003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919473003/40001
4 years, 7 months ago (2016-04-29 00:09:09 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-29 00:34:56 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:22:58 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/79fb44bf5c05683a19f378e85afd74c705b3ac8c
Cr-Commit-Position: refs/heads/master@{#390544}

Powered by Google App Engine
This is Rietveld 408576698