Support for mapping from outer/visual to flowthread coord space in nested multicol.

Support for mapping from outer/visual to flowthread coord space in nested multicol.

Committed: https://crrev.com/1ccf932a2f44faecebbcc1836e5ddc54fea4d865
Cr-Commit-Position: refs/heads/master@{#389249}

[mstensho (USE GERRIT), 2016-04-22 19:33:56]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, leviw@chromium.org, szager@chromium.org,
wkorman@chromium.org

[eae, 2016-04-22 19:35:40]

https://codereview.chromium.org/1919453002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp (right):

https://codereview.chromium.org/1919453002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp:75: return
m_fragmentainerGroups.last();
Do we need to assert that there is at least one entry in m_fragmentainerGroups?

[eae, 2016-04-22 19:38:34]

LGTM

[wkorman, 2016-04-22 19:39:45]

lgtm

[mstensho (USE GERRIT), 2016-04-22 19:46:00]

https://codereview.chromium.org/1919453002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp (right):

https://codereview.chromium.org/1919453002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp:75: return
m_fragmentainerGroups.last();
On 2016/04/22 19:35:39, eae wrote:
> Do we need to assert that there is at least one entry in
m_fragmentainerGroups?

I was thinking that it really shouldn't be necessary, but I see now that
fragmentainerGroupIndexAtFlowThreadOffset() (the method above) does it, so I
think it makes sense to add it here too, for the sake of consistency and lurking
dragons.

Done.

[mstensho (USE GERRIT), 2016-04-22 19:46:32]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-04-22 19:46:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
wkorman@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1919453002/#ps40001
(title: "Add assert.")

[eae, 2016-04-22 19:46:33]

Thanks!
LGTM

[commit-bot: I haz the power, 2016-04-22 19:47:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919453002/40001

[commit-bot: I haz the power, 2016-04-22 21:33:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 21:36:28]

Description was changed from

==========
Support for mapping from outer/visual to flowthread coord space in nested
multicol.
==========

to

==========
Support for mapping from outer/visual to flowthread coord space in nested
multicol.

Committed: https://crrev.com/1ccf932a2f44faecebbcc1836e5ddc54fea4d865
Cr-Commit-Position: refs/heads/master@{#389249}
==========

[commit-bot: I haz the power, 2016-04-22 21:36:29]

Patchset 3 (id:??) landed as
https://crrev.com/1ccf932a2f44faecebbcc1836e5ddc54fea4d865
Cr-Commit-Position: refs/heads/master@{#389249}