Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1919453002: Support for mapping from outer/visual to flowthread coord space in nested multicol. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support for mapping from outer/visual to flowthread coord space in nested multicol. Committed: https://crrev.com/1ccf932a2f44faecebbcc1836e5ddc54fea4d865 Cr-Commit-Position: refs/heads/master@{#389249}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase master #

Patch Set 3 : Add assert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -25 lines) Patch
A + third_party/WebKit/LayoutTests/fast/multicol/event-offset-in-nested.html View 2 chunks +38 lines, -17 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/multicol/event-offset-in-nested-expected.txt View 2 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp View 1 chunk +13 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-22 19:33:56 UTC) #2
eae
https://codereview.chromium.org/1919453002/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp File third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp (right): https://codereview.chromium.org/1919453002/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp#newcode75 third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp:75: return m_fragmentainerGroups.last(); Do we need to assert that there ...
4 years, 8 months ago (2016-04-22 19:35:40 UTC) #3
eae
LGTM
4 years, 8 months ago (2016-04-22 19:38:34 UTC) #4
wkorman
lgtm
4 years, 8 months ago (2016-04-22 19:39:45 UTC) #5
mstensho (USE GERRIT)
https://codereview.chromium.org/1919453002/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp File third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp (right): https://codereview.chromium.org/1919453002/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp#newcode75 third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp:75: return m_fragmentainerGroups.last(); On 2016/04/22 19:35:39, eae wrote: > Do ...
4 years, 8 months ago (2016-04-22 19:46:00 UTC) #6
eae
Thanks! LGTM
4 years, 8 months ago (2016-04-22 19:46:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919453002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919453002/40001
4 years, 8 months ago (2016-04-22 19:47:07 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-22 21:33:56 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 21:36:29 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1ccf932a2f44faecebbcc1836e5ddc54fea4d865
Cr-Commit-Position: refs/heads/master@{#389249}

Powered by Google App Engine
This is Rietveld 408576698