Remove CFX_MapPtrTemplate usage in fsdk_baseform.cpp

Remove CFX_MapPtrTemplate usage in fsdk_baseform.cpp

Replace one instance with std::map.
Remove another instance that is never inserted into.

Committed: https://pdfium.googlesource.com/pdfium/+/16a2033b3b7e2e348509c9938d77268e85e2b763

[Tom Sepez, 2016-04-22 17:41:08]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-22 17:41:09]

Lei, please review.

[Tom Sepez, 2016-04-22 17:45:33]

Description was changed from

==========
Remove CFX_MapPtrTemplate usage in fsdk_baseform

Replace one instance with std::map.
Remove another instance that is never inserted into.
==========

to

==========
Remove CFX_MapPtrTemplate usage in fsdk_baseform.cpp

Replace one instance with std::map.
Remove another instance that is never inserted into.
==========

[Lei Zhang, 2016-04-22 19:40:45]

lgtm

https://codereview.chromium.org/1919433002/diff/20001/fpdfsdk/fsdk_baseform.cpp
File fpdfsdk/fsdk_baseform.cpp (left):

https://codereview.chromium.org/1919433002/diff/20001/fpdfsdk/fsdk_baseform.c...
fpdfsdk/fsdk_baseform.cpp:2463: ASSERT(pFormCtrl);
Should we assert that we're never adding/erasing/getting a NULL widget from
|m_XFAMap| ?

[Tom Sepez, 2016-04-22 20:39:13]

https://codereview.chromium.org/1919433002/diff/20001/fpdfsdk/fsdk_baseform.cpp
File fpdfsdk/fsdk_baseform.cpp (left):

https://codereview.chromium.org/1919433002/diff/20001/fpdfsdk/fsdk_baseform.c...
fpdfsdk/fsdk_baseform.cpp:2463: ASSERT(pFormCtrl);
On 2016/04/22 19:40:45, Lei Zhang wrote:
> Should we assert that we're never adding/erasing/getting a NULL widget from
> |m_XFAMap| ?

Done.

[Tom Sepez, 2016-04-22 21:00:34]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-22 21:00:35]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1919433002/#ps40001
(title: "Add asserts.")

[commit-bot: I haz the power, 2016-04-22 21:00:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919433002/40001

[commit-bot: I haz the power, 2016-04-22 21:00:50]

Description was changed from

==========
Remove CFX_MapPtrTemplate usage in fsdk_baseform.cpp

Replace one instance with std::map.
Remove another instance that is never inserted into.
==========

to

==========
Remove CFX_MapPtrTemplate usage in fsdk_baseform.cpp

Replace one instance with std::map.
Remove another instance that is never inserted into.

Committed:
https://pdfium.googlesource.com/pdfium/+/16a2033b3b7e2e348509c9938d77268e85e2...
==========

[commit-bot: I haz the power, 2016-04-22 21:00:51]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/16a2033b3b7e2e348509c9938d77268e85e2...