Issue 1919403003: Revert of Add some code to ensure that stdout is always flushed and closed to help debug l

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1919403003: Revert of Add some code to ensure that stdout is always flushed and closed to help debug l (Closed)

Created:
4 years, 7 months ago by jam

Modified:
4 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build@master

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

Revert of Add some code to ensure that stdout is always flushed and closed to help debug layout tests hanging… (patchset #1 id:1 of https://codereview.chromium.org/1914243002/ ) Reason for revert: hang still occurred: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/211734 Original issue's description: > Add some code to ensure that stdout is always flushed and closed to help debug layout tests hanging on Windows trybots. > > BUG=522396 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300202 TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=522396

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	scripts/slave/chromium/layout_test_wrapper.py	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 5 (3 generated)

jam

Created Revert of Add some code to ensure that stdout is always flushed and closed ...

4 years, 7 months ago (2016-04-26 21:49:37 UTC) #1

lgtm