Small cleanup of SiteEngagementService.

chrome/browser/engagement/site_engagement_service.h

Index: chrome/browser/engagement/site_engagement_service.h
diff --git a/chrome/browser/engagement/site_engagement_service.h b/chrome/browser/engagement/site_engagement_service.h
index 1d733322e887cced1264f0a6ac062984c06b8a99..4bc04190952a92ee5e8f7dd2ab9e04168acbc3e6 100644
--- a/chrome/browser/engagement/site_engagement_service.h
+++ b/chrome/browser/engagement/site_engagement_service.h
@@ -29,6 +29,7 @@ class HistoryService;
 
 class GURL;
 class Profile;
+class SiteEngagementScore;
 
 class SiteEngagementScoreProvider {
  public:
@@ -130,6 +131,9 @@ class SiteEngagementService : public KeyedService,
   // maximum limits for the day and overall.
   void AddPoints(const GURL& url, double points);

[dominickn, 2016/05/25 06:52:43]

const

 
+  // Retrieves the SiteEngagementScore object for |origin|.
+  SiteEngagementScore GetEngagementScore(const GURL& origin) const;

[dominickn, 2016/05/25 06:52:43]

This could be in the anonymous namespace in site_engagement_sevice.cc, taking a
clock pointer and origin argument. Then you don't need the forward declaration
of SiteEngagementScore.

[calamity, 2016/05/26 08:26:20]

I'd rather not do that for two reasons:
- I'd have to pass clock_ and profile_ at every call which is a bit verbose for
no reason.
- It would allow const setters again. Blech.

[dominickn, 2016/05/26 09:33:20]

Acknowledged.

+
   // Post startup tasks: cleaning up origins which have decayed to 0, and
   // logging UMA statistics.
   void AfterStartupTask();
@@ -172,13 +176,6 @@ class SiteEngagementService : public KeyedService,
     bool expired,
     const history::OriginCountAndLastVisitMap& remaining_origin_counts);

[dominickn, 2016/05/25 06:52:43]

Can this method be const now?

[calamity, 2016/05/26 08:26:20]

Not anymore ;)

[dominickn, 2016/05/26 09:33:20]

Acknowledged.

 
-  // Resets the engagement score for |url| to |score|, and sets the last
-  // engagement time and last shortcut launch time (if it is non-null) to
-  // |updated_time|. Clears daily limits.
-  void ResetScoreAndAccessTimesForURL(const GURL& url,
-                                      double score,
-                                      const base::Time* updated_time);
-
   Profile* profile_;
 
   // The clock used to vend times.