Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4919)

Unified Diff: chrome/browser/engagement/site_engagement_service_unittest.cc

Issue 1919383005: Small cleanup of SiteEngagementService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service_unittest.cc
diff --git a/chrome/browser/engagement/site_engagement_service_unittest.cc b/chrome/browser/engagement/site_engagement_service_unittest.cc
index f88fbf1e64bc690e3e71502341f1b8590b70b929..9b5f234f34e3af6dcbd3ef38e3631b8c4dec9477 100644
--- a/chrome/browser/engagement/site_engagement_service_unittest.cc
+++ b/chrome/browser/engagement/site_engagement_service_unittest.cc
@@ -433,7 +433,7 @@ TEST_F(SiteEngagementScoreTest, Reset) {
current_day += base::TimeDelta::FromDays(7);
test_clock_.SetNow(current_day);
- score_.Reset(20.0, nullptr);
+ score_.Reset(20.0, test_clock_.Now());
EXPECT_DOUBLE_EQ(20.0, score_.Score());
EXPECT_DOUBLE_EQ(0, score_.points_added_today_);
EXPECT_EQ(current_day, score_.last_engagement_time_);
@@ -453,7 +453,7 @@ TEST_F(SiteEngagementScoreTest, Reset) {
score_.AddPoints(5);
test_clock_.SetNow(GetReferenceTime());
base::Time now = test_clock_.Now();
- score_.Reset(10.0, &now);
+ score_.Reset(10.0, now);
EXPECT_DOUBLE_EQ(10.0, score_.Score());
EXPECT_DOUBLE_EQ(0, score_.points_added_today_);
@@ -461,15 +461,16 @@ TEST_F(SiteEngagementScoreTest, Reset) {
EXPECT_TRUE(score_.last_shortcut_launch_time_.is_null());
score_.set_last_shortcut_launch_time(test_clock_.Now());
+ base::Time old_now = test_clock_.Now();
test_clock_.SetNow(GetReferenceTime() + base::TimeDelta::FromDays(3));
now = test_clock_.Now();
- score_.Reset(15.0, &now);
+ score_.Reset(15.0, now);
// 5 bonus from the last shortcut launch.
EXPECT_DOUBLE_EQ(20.0, score_.Score());
EXPECT_DOUBLE_EQ(0, score_.points_added_today_);
EXPECT_EQ(now, score_.last_engagement_time_);
- EXPECT_EQ(now, score_.last_shortcut_launch_time_);
+ EXPECT_EQ(old_now, score_.last_shortcut_launch_time_);
}
class SiteEngagementServiceTest : public ChromeRenderViewHostTestHarness {

Powered by Google App Engine
This is Rietveld 408576698