GN: Put BoringSSL Chromium specific targets inside a condition

third_party/boringssl/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//testing/libfuzzer/fuzzer_test.gni")
 import("BUILD.generated.gni")
 import("BUILD.generated_tests.gni")
 
+declare_args() {
+  include_boringssl_unittests = false

[davidben, 2016/04/26 21:07:56]

Oh. Actually, I would rather we at least build this, even if it's not getting
run. We at least get compile-testing and, as discussed out-of-band, it's work
along the way to getting in-Chromium embeddings of tests. That they're not
running right now is something I was actively fixing before the WebRTC circular
dependency came up.

[davidben, 2016/04/26 21:12:12]

That or we should decide this is not a thing we can support at all and we just
take the targets out completely. But since we already have the Chromium-specific
fuzzer tests and those have become invaluable quickly, I think the idea that we
cannot have any Chromium-specific BoringSSL targets at all is untenable.

+}
+
 # Config for us and everybody else depending on BoringSSL.
 config("external_config") {
   include_dirs = [ "src/include" ]
   if (is_component_build) {
     defines = [ "BORINGSSL_SHARED_LIBRARY" ]
   }
 }
 
 # Config internal to this build file, shared by boringssl and boringssl_fuzzer.
 config("internal_config") {
@@ skipping 103 matching lines @@
   }
 }
 
 create_tests("boringssl_tests") {
   configs = [ ":internal_config" ]
   deps = [
     ":boringssl",
   ]
 }
 
-test("boringssl_unittests") {
-  deps = [
-    ":boringssl_tests",
-    "//base",
-    "//base/test:run_all_unittests",
-    "//base/test:test_support",
-    "//testing/gtest",
-  ]
-  sources = [
-    "boringssl_unittest.cc",
-  ]
+if (include_boringssl_unittests) {
+  test("boringssl_unittests") {
+    deps = [
+      ":boringssl_tests",
+      "//base",
+      "//base/test:run_all_unittests",
+      "//base/test:test_support",
+      "//testing/gtest",
+    ]
+    sources = [
+      "boringssl_unittest.cc",
+    ]
+  }
 }
 
 # The same as boringssl, but builds with BORINGSSL_UNSAFE_FUZZER_MODE.
 component("boringssl_fuzzer") {

[davidben, 2016/04/26 21:05:10]

Do you want to omit all these other bits too? (boringssl_fuzzer and the
fuzzer_test foreach.) I'm actually kind of confused how that is working at all,
but I bet it's only working on accident.

   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   sources = all_sources
   deps = [
     ":boringssl_asm",
   ]
 
   public_configs = [
     ":external_config",
     ":fuzzer_config",
@@ skipping 12 matching lines @@
   fuzzer_test("boringssl_${fuzzer}_fuzzer") {
     sources = [
       "src/fuzz/${fuzzer}.cc",
     ]
     deps = [
       ":boringssl_fuzzer",
     ]
     seed_corpus = "src/fuzz/${fuzzer}_corpus"
   }
 }