Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1919373002: [Mac/GN] Fix Crashpad build and include some targets in gn_all. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Fix Crashpad build and include some targets in gn_all. BUG=431177 R=scottmg@chromium.org Committed: https://crrev.com/985bd81676559f5df422343a790e6640e92a4849 Cr-Commit-Position: refs/heads/master@{#389882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M build/secondary/third_party/crashpad/crashpad/compat/BUILD.gn View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Robert Sesek
4 years, 7 months ago (2016-04-26 20:07:55 UTC) #1
scottmg
Probably almost time for https://bugs.chromium.org/p/crashpad/issues/detail?id=79. lgtm
4 years, 7 months ago (2016-04-26 20:09:41 UTC) #2
Robert Sesek
+dpranke for OWNERS
4 years, 7 months ago (2016-04-26 20:13:00 UTC) #4
Robert Sesek
On 2016/04/26 20:09:41, scottmg wrote: > Probably almost time for > https://bugs.chromium.org/p/crashpad/issues/detail?id=79. Yeah, was talking ...
4 years, 7 months ago (2016-04-26 20:13:19 UTC) #5
Dirk Pranke
lgtm
4 years, 7 months ago (2016-04-26 20:37:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919373002/1
4 years, 7 months ago (2016-04-26 20:39:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 21:06:28 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 21:08:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/985bd81676559f5df422343a790e6640e92a4849
Cr-Commit-Position: refs/heads/master@{#389882}

Powered by Google App Engine
This is Rietveld 408576698