media/base/android/media_source_player_unittest.cc - Issue 191933002: This is initial API support required for enabling SurfaceTexture backed zero-copy for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_source_player_unittest.cc

Issue 191933002: This is initial API support required for enabling SurfaceTexture backed zero-copy for Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build issues Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/tests/gl_unittests_android.cc ('k') | ui/android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformWrapper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_source_player_unittest.cc

diff --git a/media/base/android/media_source_player_unittest.cc b/media/base/android/media_source_player_unittest.cc

index 1273ecbc00715f9f8311a747e79f73b8510b467e..7a85b0427058bfbc0b0ccd92eae756d41f7fa167 100644

--- a/media/base/android/media_source_player_unittest.cc

+++ b/media/base/android/media_source_player_unittest.cc

@@ -610,10 +610,10 @@ class MediaSourcePlayerTest : public testing::Test {

void CreateNextTextureAndSetVideoSurface() {

gfx::SurfaceTexture* surface_texture;

if (surface_texture_a_is_next_) {

- surface_texture_a_ = new gfx::SurfaceTexture(next_texture_id_++);

+ surface_texture_a_ = gfx::SurfaceTexture::Create(next_texture_id_++);

surface_texture = surface_texture_a_.get();

} else {

- surface_texture_b_ = new gfx::SurfaceTexture(next_texture_id_++);

+ surface_texture_b_ = gfx::SurfaceTexture::Create(next_texture_id_++);

surface_texture = surface_texture_b_.get();

}

@@ -817,7 +817,7 @@ TEST_F(MediaSourcePlayerTest, StartVideoCodecWithInvalidSurface) {

// Test video decoder job will not be created when surface is invalid.

scoped_refptr<gfx::SurfaceTexture> surface_texture(

- new gfx::SurfaceTexture(0));

+ gfx::SurfaceTexture::Create(0));

gfx::ScopedJavaSurface surface(surface_texture.get());

StartVideoDecoderJob(false);