Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 1919323002: Added media_features dependency for media gpu targets (Closed)

Created:
4 years, 8 months ago by servolk
Modified:
4 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added media_features dependency for media gpu targets BUG=606829 TBR=miu,wolenetz NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Committed: https://crrev.com/094a8272083fe95308dcd9f23ea008cb438df25d Cr-Commit-Position: refs/heads/master@{#389822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/gpu/ipc/client/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/ipc/media_ipc.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Charlie Reis
Rubber stamp LGTM as sheriff to get the tree open; TBR'ing miu and wolenetz.
4 years, 8 months ago (2016-04-26 18:30:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919323002/1
4 years, 8 months ago (2016-04-26 18:44:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 18:45:27 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/094a8272083fe95308dcd9f23ea008cb438df25d Cr-Commit-Position: refs/heads/master@{#389822}
4 years, 8 months ago (2016-04-26 18:47:02 UTC) #10
miu
lgtm
4 years, 8 months ago (2016-04-26 18:50:56 UTC) #11
wolenetz
lgtm
4 years, 8 months ago (2016-04-26 22:27:43 UTC) #12
wolenetz
TBR+=sandersd@ (neither miu@ nor myself are in media/gpu/OWNERS)
4 years, 8 months ago (2016-04-26 22:29:19 UTC) #14
sandersd (OOO until July 31)
4 years, 8 months ago (2016-04-26 22:32:09 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698