Issue 1919313002: ApplicationImpl::ConnectToServiceDeprecated() -> mojo::ConnectToService() conversion, part 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1919313002: ApplicationImpl::ConnectToServiceDeprecated() -> mojo::ConnectToService() conversion, part 3. (Closed)

Created:
4 years, 8 months ago by viettrungluu

Modified:
4 years, 8 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

ApplicationImpl::ConnectToServiceDeprecated() -> mojo::ConnectToService() conversion, part 3. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c1248b2610a756d2db2b2f055e289dff518a0581

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -30 lines)			Patch
M	services/test_service/test_service_impl.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	services/test_service/test_time_service_impl.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	services/ui/launcher/launch_instance.cc	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	services/ui/view_manager/view_associate_table.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	services/ui/view_manager/view_manager_app.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	services/url_response_disk_cache/url_response_disk_cache_apptest.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	shell/android/android_handler.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	shell/android/nfc_apptest.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	shell/shell_apptest.cc	View	5 chunks	+12 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

viettrungluu

4 years, 8 months ago (2016-04-26 20:42:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c1248b2610a756d2db2b2f055e289dff518a0581 (presubmit successful).