Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1919283003: Fixes and enables FindCodeObject test for dbc (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Vyacheslav Egorov (Google)
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes and enables FindCodeObject test for dbc DBC always encodes branches similarly to arm64's far branches. In particular, the unconditional jump takes a signed 26-bit offset. This CL just modifies the test to generate enough code to test that dbc can handle branches the same distance as the other platforms. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/db86be4901f39ad913ce1b0f459a25e20eca366a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/find_code_object_test.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 8 months ago (2016-04-26 17:30:47 UTC) #2
Ivan Posva
LGTM -ip
4 years, 8 months ago (2016-04-26 17:38:53 UTC) #3
zra
4 years, 8 months ago (2016-04-26 17:40:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db86be4901f39ad913ce1b0f459a25e20eca366a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698