Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1919223003: Sampling heap profiler: remove empty nodes from profile. (Closed)

Created:
4 years, 8 months ago by alph
Modified:
4 years, 7 months ago
Reviewers:
ofrobots, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Sampling heap profiler: remove empty nodes from profile. Committed: https://crrev.com/a4fa471a33a5bf615e1ff9963c825ffca8cbca0e Cr-Commit-Position: refs/heads/master@{#35884}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M src/profiler/sampling-heap-profiler.h View 1 2 chunks +8 lines, -4 lines 0 comments Download
M src/profiler/sampling-heap-profiler.cc View 1 6 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919223003/1
4 years, 8 months ago (2016-04-27 01:30:23 UTC) #2
alph
4 years, 8 months ago (2016-04-27 01:32:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-27 01:51:23 UTC) #6
ofrobots
On 2016/04/27 01:51:23, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-04-27 18:39:40 UTC) #7
ulan
lgtm https://codereview.chromium.org/1919223003/diff/1/src/profiler/sampling-heap-profiler.cc File src/profiler/sampling-heap-profiler.cc (right): https://codereview.chromium.org/1919223003/diff/1/src/profiler/sampling-heap-profiler.cc#newcode61 src/profiler/sampling-heap-profiler.cc:61: profile_root_(NULL, "(root)", v8::UnboundScript::kNoScriptId, 0), nullptr
4 years, 7 months ago (2016-04-28 09:11:57 UTC) #8
alph
https://codereview.chromium.org/1919223003/diff/1/src/profiler/sampling-heap-profiler.cc File src/profiler/sampling-heap-profiler.cc (right): https://codereview.chromium.org/1919223003/diff/1/src/profiler/sampling-heap-profiler.cc#newcode61 src/profiler/sampling-heap-profiler.cc:61: profile_root_(NULL, "(root)", v8::UnboundScript::kNoScriptId, 0), On 2016/04/28 09:11:57, ulan wrote: ...
4 years, 7 months ago (2016-04-28 22:14:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919223003/20001
4 years, 7 months ago (2016-04-28 22:14:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 22:38:26 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:07 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a4fa471a33a5bf615e1ff9963c825ffca8cbca0e
Cr-Commit-Position: refs/heads/master@{#35884}

Powered by Google App Engine
This is Rietveld 408576698