Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1919223002: Initialize the notification bridge instead of the UIManager on Android (Closed)

Created:
4 years, 7 months ago by Miguel Garcia
Modified:
4 years, 7 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize the notification bridge instead of the UIManager on Android BUG=596161 Committed: https://crrev.com/d29366e615abf76bb82f531c2846b878557a4318 Cr-Commit-Position: refs/heads/master@{#389783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/notifications/notification_ui_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Miguel Garcia
4 years, 7 months ago (2016-04-26 14:23:01 UTC) #2
Peter Beverloo
lgtm
4 years, 7 months ago (2016-04-26 14:25:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919223002/1
4 years, 7 months ago (2016-04-26 14:25:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 15:19:00 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 15:20:58 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d29366e615abf76bb82f531c2846b878557a4318
Cr-Commit-Position: refs/heads/master@{#389783}

Powered by Google App Engine
This is Rietveld 408576698