Rename notification interactive_ui_tests to "*_interactive_uitest.cc" to avoid confusion.

Rename notification interactive_ui_tests to "*_interactive_uitest.cc" to avoid confusion.

It seems very confusing to have "chrome/*/*_browsertest.cc" files that
are not actually compiled in the browsertest target. I spent a long time
trying to understand why the bots were finding issues I couldn't
reproduce locally.

BUG=None
R=peter@chromium.org

Committed: https://crrev.com/26c265d3b870d79d9b1c1ac0597c2bf151efd836
Cr-Commit-Position: refs/heads/master@{#389794}

[mlamouri (slow - plz ping), 2016-04-26 13:54:37]

I would be happy to rename the file with "interactive_browsertest.cc" but it is
an uncommon suffix.

[mlamouri (slow - plz ping), 2016-04-26 13:54:45]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 13:54:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919203002/1

[Peter Beverloo, 2016-04-26 14:00:58]

Thank you, Mounir!

Would you mind naming them *_interactive_uitest.cc instead? It looks like the
*_ui_browsertest.cc suffix are actually browser tests for files named *_ui.cc
(i.e. user_manager_ui.cc / user_manager_ui_browsertest.cc).

lgtm with that change

[mlamouri (slow - plz ping), 2016-04-26 14:23:37]

Description was changed from

==========
Rename notification interactive_ui_tests to "ui_browsertest.cc" to avoid
confusion.

It seems very confusing to have "chrome/*/*_browsertest.cc" files that
are not actually compiled in the browsertest target. I spent a long time
trying to understand why the bots were finding issues I couldn't
reproduce locally.

BUG=None
R=peter@chromium.org
==========

to

==========
Rename notification interactive_ui_tests to "*_interactive_uitest.cc" to avoid
confusion.

It seems very confusing to have "chrome/*/*_browsertest.cc" files that
are not actually compiled in the browsertest target. I spent a long time
trying to understand why the bots were finding issues I couldn't
reproduce locally.

BUG=None
R=peter@chromium.org
==========

[mlamouri (slow - plz ping), 2016-04-26 14:23:41]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-04-26 14:23:41]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1919203002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-04-26 14:23:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919203002/20001

[commit-bot: I haz the power, 2016-04-26 14:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 14:37:33]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[mlamouri (slow - plz ping), 2016-04-26 14:51:09]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-04-26 14:51:10]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1919203002/#ps40001
(title: "fix rename")

[commit-bot: I haz the power, 2016-04-26 14:51:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919203002/40001

[commit-bot: I haz the power, 2016-04-26 15:55:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-26 15:57:28]

Description was changed from

==========
Rename notification interactive_ui_tests to "*_interactive_uitest.cc" to avoid
confusion.

It seems very confusing to have "chrome/*/*_browsertest.cc" files that
are not actually compiled in the browsertest target. I spent a long time
trying to understand why the bots were finding issues I couldn't
reproduce locally.

BUG=None
R=peter@chromium.org
==========

to

==========
Rename notification interactive_ui_tests to "*_interactive_uitest.cc" to avoid
confusion.

It seems very confusing to have "chrome/*/*_browsertest.cc" files that
are not actually compiled in the browsertest target. I spent a long time
trying to understand why the bots were finding issues I couldn't
reproduce locally.

BUG=None
R=peter@chromium.org

Committed: https://crrev.com/26c265d3b870d79d9b1c1ac0597c2bf151efd836
Cr-Commit-Position: refs/heads/master@{#389794}
==========

[commit-bot: I haz the power, 2016-04-26 15:57:30]

Patchset 3 (id:??) landed as
https://crrev.com/26c265d3b870d79d9b1c1ac0597c2bf151efd836
Cr-Commit-Position: refs/heads/master@{#389794}