scripts/slave/recipe_modules/filter/example.expected/bad_retcode_fails.json - Issue 1919193002: build: roll infra_paths changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/filter/example.expected/bad_retcode_fails.json

Issue 1919193002: build: roll infra_paths changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: merge Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/filter/example.expected/analyzes_returns_true.json ('k') | scripts/slave/recipe_modules/filter/example.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/filter/example.expected/bad_retcode_fails.json

diff --git a/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_fails.json b/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_fails.json

index ea6163c66d9e8007f7ef5759f74e5fcdb01278fe..3503b3fc593043cfbef0901e7547e8039ca6c0b0 100644

--- a/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_fails.json

+++ b/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_fails.json

@@ -4,10 +4,9 @@

"python",

"-u",

"\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

- "[SLAVE_BUILD]/testing/buildbot/trybot_analyze_config.json",

+ "[CWD]/testing/buildbot/trybot_analyze_config.json",

"/path/to/tmp/json"

- "cwd": "[SLAVE_BUILD]",

"name": "read filter exclusion spec",

"~followup_annotations": [

"@@@STEP_TEXT@path: 'testing/buildbot/trybot_analyze_config.json'@@@",

@@ -29,15 +28,14 @@

"cmd": [

"python",

"-u",

- "[SLAVE_BUILD]/build/gyp_chromium",

+ "[CWD]/build/gyp_chromium",

"--analyzer",

"{\"additional_compile_targets\": [], \"files\": [\"foo.cc\"], \"test_targets\": []}",

"/path/to/tmp/json"

- "cwd": "[SLAVE_BUILD]",

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

- "GYP_DEFINES": "component=static_library gomadir='[BUILD]/goma' target_arch=x64 use_goma=1"

+ "GYP_DEFINES": "component=static_library gomadir='[ROOT]/b/build/goma' target_arch=x64 use_goma=1"

"name": "analyze",

"~followup_annotations": [