Cleanup: Extract icon related methods outside of util.js

ui/webui/resources/js/util.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // <include src="assert.js">
 
 /**
  * Alias for document.getElementById. Found elements must be HTMLElements.
  * @param {string} id The ID of the element to find.
  * @return {HTMLElement} The found element or null if not found.
@@ skipping 28 matching lines @@
   element.style.left = '-9999px';
   element.style.height = '0px';
   element.innerText = msg;
   document.body.appendChild(element);
   window.setTimeout(function() {
     document.body.removeChild(element);
   }, 0);
 }
 
 /**
- * Returns the scale factors supported by this platform for webui
- * resources.
- * @return {Array} The supported scale factors.
- */
-function getSupportedScaleFactors() {
-  var supportedScaleFactors = [];
-  if (cr.isMac || cr.isChromeOS || cr.isWindows || cr.isLinux) {
-    // All desktop platforms support zooming which also updates the
-    // renderer's device scale factors (a.k.a devicePixelRatio), and
-    // these platforms has high DPI assets for 2.0x. Use 1x and 2x in
-    // image-set on these platforms so that the renderer can pick the
-    // closest image for the current device scale factor.
-    supportedScaleFactors.push(1);
-    supportedScaleFactors.push(2);
-  } else {
-    // For other platforms that use fixed device scale factor, use
-    // the window's device pixel ratio.
-    // TODO(oshima): Investigate if Android/iOS need to use image-set.
-    supportedScaleFactors.push(window.devicePixelRatio);
-  }
-  return supportedScaleFactors;
-}
-
-/**
  * Generates a CSS url string.
  * @param {string} s The URL to generate the CSS url for.
  * @return {string} The CSS url string.
  */
 function url(s) {
   // http://www.w3.org/TR/css3-values/#uris
   // Parentheses, commas, whitespace characters, single quotes (') and double
   // quotes (") appearing in a URI must be escaped with a backslash
   var s2 = s.replace(/(\(|\)|\,|\s|\'|\"|\\)/g, '\\$1');
   // WebKit has a bug when it comes to URLs that end with \
   // https://bugs.webkit.org/show_bug.cgi?id=28885
   if (/\\\\$/.test(s2)) {
     // Add a space to work around the WebKit bug.
     s2 += ' ';
   }
   return 'url("' + s2 + '")';
 }
 
 /**
- * Returns the URL of the image, or an image set of URLs for the profile avatar.
- * Default avatars have resources available for multiple scalefactors, whereas
- * the GAIA profile image only comes in one size.
- *
- * @param {string} path The path of the image.
- * @return {string} The url, or an image set of URLs of the avatar image.
- */
-function getProfileAvatarIcon(path) {
-  var chromeThemePath = 'chrome://theme';
-  var isDefaultAvatar =
-      (path.slice(0, chromeThemePath.length) == chromeThemePath);
-  return isDefaultAvatar ? imageset(path + '@scalefactorx'): url(path);
-}
-
-/**
- * Generates a CSS -webkit-image-set for a chrome:// url.
- * An entry in the image set is added for each of getSupportedScaleFactors().
- * The scale-factor-specific url is generated by replacing the first instance of
- * 'scalefactor' in |path| with the numeric scale factor.
- * @param {string} path The URL to generate an image set for.
- *     'scalefactor' should be a substring of |path|.
- * @return {string} The CSS -webkit-image-set.
- */
-function imageset(path) {
-  var supportedScaleFactors = getSupportedScaleFactors();
-
-  var replaceStartIndex = path.indexOf('scalefactor');
-  if (replaceStartIndex < 0)
-    return url(path);
-
-  var s = '';
-  for (var i = 0; i < supportedScaleFactors.length; ++i) {
-    var scaleFactor = supportedScaleFactors[i];
-    var pathWithScaleFactor = path.substr(0, replaceStartIndex) + scaleFactor +
-        path.substr(replaceStartIndex + 'scalefactor'.length);
-
-    s += url(pathWithScaleFactor) + ' ' + scaleFactor + 'x';
-
-    if (i != supportedScaleFactors.length - 1)
-      s += ', ';
-  }
-  return '-webkit-image-set(' + s + ')';
-}
-
-/**
  * Parses query parameters from Location.
  * @param {Location} location The URL to generate the CSS url for.
  * @return {Object} Dictionary containing name value pairs for URL
  */
 function parseQueryParams(location) {
   var params = {};
   var query = unescape(location.search.substring(1));
   var vars = query.split('&');
   for (var i = 0; i < vars.length; i++) {
     var pair = vars[i].split('=');
@@ skipping 171 matching lines @@
  */
 function appendParam(url, key, value) {
   var param = encodeURIComponent(key) + '=' + encodeURIComponent(value);
 
   if (url.indexOf('?') == -1)
     return url + '?' + param;
   return url + '&' + param;
 }
 
 /**
- * A regular expression for identifying favicon URLs.
- * @const {!RegExp}
- * TODO(dpapad): Move all favicon related methods to a new favicon_util.js file
- * and make this RegExp private.
- */
-var FAVICON_URL_REGEX = /\.ico$/i;
-
-/**
- * Creates a CSS -webkit-image-set for a favicon request.
- * @param {string} url Either the URL of the original page or of the favicon
- *     itself.
- * @param {number=} opt_size Optional preferred size of the favicon.
- * @param {string=} opt_type Optional type of favicon to request. Valid values
- *     are 'favicon' and 'touch-icon'. Default is 'favicon'.
- * @return {string} -webkit-image-set for the favicon.
- */
-function getFaviconImageSet(url, opt_size, opt_type) {
-  var size = opt_size || 16;
-  var type = opt_type || 'favicon';
-
-  return imageset(
-      'chrome://' + type + '/size/' + size + '@scalefactorx/' +
-      // Note: Literal 'iconurl' must match |kIconURLParameter| in
-      // components/favicon_base/favicon_url_parser.cc.
-      (FAVICON_URL_REGEX.test(url) ? 'iconurl/' : '') + url);
-}
-
-/**
  * Creates an element of a specified type with a specified class name.
  * @param {string} type The node type.
  * @param {string} className The class name to use.
  * @return {Element} The created element.
  */
 function createElementWithClassName(type, className) {
   var elm = document.createElement(type);
   elm.className = className;
   return elm;
 }
@@ skipping 16 matching lines @@
     opt_timeOut += 50;
   }
 
   var fired = false;
   el.addEventListener('webkitTransitionEnd', function f(e) {
     el.removeEventListener('webkitTransitionEnd', f);
     fired = true;
   });
   window.setTimeout(function() {
     if (!fired)
       cr.dispatchSimpleEvent(el, 'webkitTransitionEnd', true);

[Dan Beam, 2016/05/06 22:39:06]

because ^

[dpapad, 2016/05/06 22:56:33]

Expanding on previous comment, this file as a whole depends on cr.js, but the
the only method being tested is quoteString(), therefore util_test.html does not
depend on cr.js.

   }, opt_timeOut);
 }
 
 /**
  * Alias for document.scrollTop getter.
  * @param {!HTMLDocument} doc The document node where information will be
  *     queried from.
  * @return {number} The Y document scroll offset.
  */
 function scrollTopForDocument(doc) {
@@ skipping 59 matching lines @@
 }
 
 /**
  * Quote a string so it can be used in a regular expression.
  * @param {string} str The source string.
  * @return {string} The escaped string.
  */
 function quoteString(str) {
   return str.replace(/([\\\.\+\*\?\[\^\]\$\(\)\{\}\=\!\<\>\|\:])/g, '\\$1');
 }