chrome/browser/resources/settings/search_engines_page/search_engine_entry.html - Issue 1919183005: Cleanup: Extract icon related methods outside of util.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

Issue 1919183005: Cleanup: Extract icon related methods outside of util.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename favicon.html to icon.html Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js ('k') | chrome/browser/resources/settings/search_engines_page/search_engine_entry.js » ('j') | chrome/test/data/webui/webui_resource_browsertest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_icons.html">	1 <link rel="import" href="chrome://resources/cr_elements/cr_icons.html">

2 <link rel="import" href="chrome://resources/html/polymer.html">	2 <link rel="import" href="chrome://resources/html/polymer.html">

3 <link rel="import" href="chrome://resources/html/util.html">	3 <link rel="import" href="chrome://resources/html/icon.html">

4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html">	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html">

5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

7 <link rel="import" href="chrome://md-settings/search_engines_page/search_engine_ dialog.html">	7 <link rel="import" href="chrome://md-settings/search_engines_page/search_engine_ dialog.html">

8 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines _browser_proxy.html">	8 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines _browser_proxy.html">

9 <link rel="import" href="chrome://md-settings/settings_shared_css.html">	9 <link rel="import" href="chrome://md-settings/settings_shared_css.html">

10	10

11 <dom-module id="settings-search-engine-entry">	11 <dom-module id="settings-search-engine-entry">

12 <link rel="import" type="css" href="chrome://md-settings/search_engines_page/s earch_engine_entry.css">	12 <link rel="import" type="css" href="chrome://md-settings/search_engines_page/s earch_engine_entry.css">

13 <template>	13 <template>

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 hidden$="[[!engine.canBeEdited]]" id="edit"></paper-item>	56 hidden$="[[!engine.canBeEdited]]" id="edit"></paper-item>

57 <paper-item on-tap="onDeleteTap_"	57 <paper-item on-tap="onDeleteTap_"

58 i18n-content="searchEnginesRemoveFromList"	58 i18n-content="searchEnginesRemoveFromList"

59 hidden$="[[!engine.canBeRemoved]]" id="delete"></paper-item>	59 hidden$="[[!engine.canBeRemoved]]" id="delete"></paper-item>

60 <div>	60 <div>

61 </iron-dropdown>	61 </iron-dropdown>

62 </div>	62 </div>

63 </template>	63 </template>

64 <script src="search_engine_entry.js"></script>	64 <script src="search_engine_entry.js"></script>

65 </dom-module>	65 </dom-module>

OLD	NEW