Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Side by Side Diff: chrome/browser/resources/options/browser_options_startup_page_list.js

Issue 1919183005: Cleanup: Extract icon related methods outside of util.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename favicon.html to icon.html Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options.browser_options', function() { 5 cr.define('options.browser_options', function() {
6 /** @const */ var AutocompleteList = cr.ui.AutocompleteList; 6 /** @const */ var AutocompleteList = cr.ui.AutocompleteList;
7 /** @const */ var InlineEditableItem = options.InlineEditableItem; 7 /** @const */ var InlineEditableItem = options.InlineEditableItem;
8 /** @const */ var InlineEditableItemList = options.InlineEditableItemList; 8 /** @const */ var InlineEditableItemList = options.InlineEditableItemList;
9 9
10 /** 10 /**
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 pageInfo.title = loadTimeData.getString('startupAddLabel'); 50 pageInfo.title = loadTimeData.getString('startupAddLabel');
51 pageInfo.url = ''; 51 pageInfo.url = '';
52 } 52 }
53 53
54 var titleEl = this.ownerDocument.createElement('div'); 54 var titleEl = this.ownerDocument.createElement('div');
55 titleEl.className = 'title'; 55 titleEl.className = 'title';
56 titleEl.classList.add('favicon-cell'); 56 titleEl.classList.add('favicon-cell');
57 titleEl.classList.add('weakrtl'); 57 titleEl.classList.add('weakrtl');
58 titleEl.textContent = pageInfo.title; 58 titleEl.textContent = pageInfo.title;
59 if (!this.isPlaceholder) { 59 if (!this.isPlaceholder) {
60 titleEl.style.backgroundImage = getFaviconImageSet(pageInfo.url); 60 titleEl.style.backgroundImage = cr.icon.getFaviconImageSet(
61 pageInfo.url);
61 titleEl.title = pageInfo.tooltip; 62 titleEl.title = pageInfo.tooltip;
62 } 63 }
63 64
64 this.contentElement.appendChild(titleEl); 65 this.contentElement.appendChild(titleEl);
65 66
66 var urlEl = this.createEditableTextCell(pageInfo.url); 67 var urlEl = this.createEditableTextCell(pageInfo.url);
67 urlEl.className = 'url'; 68 urlEl.className = 'url';
68 urlEl.classList.add('weakrtl'); 69 urlEl.classList.add('weakrtl');
69 this.contentElement.appendChild(urlEl); 70 this.contentElement.appendChild(urlEl);
70 71
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 this.hideDropMarkerTimer_ = window.setTimeout(function() { 313 this.hideDropMarkerTimer_ = window.setTimeout(function() {
313 $('startupPagesListDropmarker').style.display = ''; 314 $('startupPagesListDropmarker').style.display = '';
314 }, 100); 315 }, 100);
315 }, 316 },
316 }; 317 };
317 318
318 return { 319 return {
319 StartupPageList: StartupPageList 320 StartupPageList: StartupPageList
320 }; 321 };
321 }); 322 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698