chrome/chrome_browser.gypi - Issue 1919183003: Rename NotificationUIManager to NotificationPlatformBridge (1/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1919183003: Rename NotificationUIManager to NotificationPlatformBridge (1/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java ('K') | « chrome/browser/notifications/notification_ui_manager_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 647f0d36db20bb183357ca8381062881f203ee45..35a231b83c991aafd87ba745c6975b41ffe60b6e 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1942,7 +1942,7 @@

'android/java/src/org/chromium/chrome/browser/metrics/VariationsSession.java',

'android/java/src/org/chromium/chrome/browser/net/qualityprovider/ExternalEstimateProviderAndroid.java',

'android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java',

- 'android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java',

+ 'android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java',

'android/java/src/org/chromium/chrome/browser/ntp/ForeignSessionHelper.java',

'android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsService.java',

'android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java',

@@ -2184,8 +2184,8 @@

# Used on Android when notifications and java_ui are enabled.

'chrome_browser_notifications_android_java_ui_sources': [

- 'browser/notifications/notification_ui_manager_android.cc',

- 'browser/notifications/notification_ui_manager_android.h',

+ 'browser/notifications/notification_platform_bridge_android.cc',

+ 'browser/notifications/notification_platform_bridge_android.h',

'browser/notifications/notification_permission_infobar_delegate.cc',

'browser/notifications/notification_permission_infobar_delegate.h',

Peter Beverloo 2016/04/26 17:06:02 nit: ordering (was wrong before you touched this t

Miguel Garcia 2016/04/26 20:10:31 Done.