Rename NotificationUIManager to NotificationPlatformBridge (1/2)

Rename NotificationUIManager to NotificationPlatformBridge (1/2)

This covers the Android files only to make it more manageable. Mac files will come in a second CL.

The message center NotificationUIManager will remain untouched

BUG=596161
Committed: https://crrev.com/dd6ae73011eb6e25c025b4be3f147638e7570b9e
Cr-Commit-Position: refs/heads/master@{#390075}

[Miguel Garcia, 2016-04-26 16:06:25]

miguelg@chromium.org changed reviewers:
+ peter@chromium.org

[Miguel Garcia, 2016-04-26 16:06:26]

I will rebase the mac conflict (That I created myself I think) but can you have
a look for now?

[Peter Beverloo, 2016-04-26 17:06:03]

Please clarify in the title that this is in scope of
NotificationUIManagerAndroid, not the NotificationUIManager and/or other
derivatives.

lgtm

https://codereview.chromium.org/1919183003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java
(right):

https://codereview.chromium.org/1919183003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java:80:
// Notification UI Manager which will take care of delivering the appropriate
events.
nit: update comment

https://codereview.chromium.org/1919183003/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1919183003/diff/1/chrome/chrome_browser.gypi#...
chrome/chrome_browser.gypi:2190:
'browser/notifications/notification_permission_infobar_delegate.h',
nit: ordering (was wrong before you touched this too)

[Miguel Garcia, 2016-04-26 19:50:37]

Description was changed from

==========
Rename NotificationUIManager to NotificationPlatformBridge (1/2)

This covers the Android files only to make it more manageable

BUG=596161
==========

to

==========
Rename NotificationUIManager to NotificationPlatformBridge (1/2)

This covers the Android files only to make it more manageable. Mac files will
come in a second CL.

The message center NotificationUIManager will remain untouched

BUG=596161
==========

[Miguel Garcia, 2016-04-26 20:10:25]

The CQ bit was checked by miguelg@chromium.org

[Miguel Garcia, 2016-04-26 20:10:25]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1919183003/#ps20001
(title: " ")

[Miguel Garcia, 2016-04-26 20:10:31]

https://codereview.chromium.org/1919183003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java
(right):

https://codereview.chromium.org/1919183003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java:80:
// Notification UI Manager which will take care of delivering the appropriate
events.
On 2016/04/26 17:06:02, Peter Beverloo wrote:
> nit: update comment

Done.

https://codereview.chromium.org/1919183003/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1919183003/diff/1/chrome/chrome_browser.gypi#...
chrome/chrome_browser.gypi:2190:
'browser/notifications/notification_permission_infobar_delegate.h',
On 2016/04/26 17:06:02, Peter Beverloo wrote:
> nit: ordering (was wrong before you touched this too)

Done.

[commit-bot: I haz the power, 2016-04-26 20:10:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919183003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919183003/20001

[commit-bot: I haz the power, 2016-04-26 20:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 20:33:03]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Miguel Garcia, 2016-04-27 13:43:26]

The CQ bit was checked by miguelg@chromium.org

[Miguel Garcia, 2016-04-27 13:43:27]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1919183003/#ps40001
(title: "Include a few extra tests I had missed")

[commit-bot: I haz the power, 2016-04-27 13:43:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919183003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919183003/40001

[Miguel Garcia, 2016-04-27 13:44:14]

The CQ bit was unchecked by miguelg@chromium.org

[Miguel Garcia, 2016-04-27 13:53:51]

The CQ bit was checked by miguelg@chromium.org

[Miguel Garcia, 2016-04-27 13:53:52]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1919183003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-27 13:54:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919183003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919183003/60001

[commit-bot: I haz the power, 2016-04-27 14:56:51]

Description was changed from

==========
Rename NotificationUIManager to NotificationPlatformBridge (1/2)

This covers the Android files only to make it more manageable. Mac files will
come in a second CL.

The message center NotificationUIManager will remain untouched

BUG=596161
==========

to

==========
Rename NotificationUIManager to NotificationPlatformBridge (1/2)

This covers the Android files only to make it more manageable. Mac files will
come in a second CL.

The message center NotificationUIManager will remain untouched

BUG=596161
==========

[commit-bot: I haz the power, 2016-04-27 14:56:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-27 14:59:19]

Description was changed from

==========
Rename NotificationUIManager to NotificationPlatformBridge (1/2)

This covers the Android files only to make it more manageable. Mac files will
come in a second CL.

The message center NotificationUIManager will remain untouched

BUG=596161
==========

to

==========
Rename NotificationUIManager to NotificationPlatformBridge (1/2)

This covers the Android files only to make it more manageable. Mac files will
come in a second CL.

The message center NotificationUIManager will remain untouched

BUG=596161

Committed: https://crrev.com/dd6ae73011eb6e25c025b4be3f147638e7570b9e
Cr-Commit-Position: refs/heads/master@{#390075}
==========

[commit-bot: I haz the power, 2016-04-27 14:59:20]

Patchset 4 (id:??) landed as
https://crrev.com/dd6ae73011eb6e25c025b4be3f147638e7570b9e
Cr-Commit-Position: refs/heads/master@{#390075}