Added media_features dependency for cast_sender target

Added media_features dependency for cast_sender target

The cast_sender target ends up including video_decoder_config.h, and
I've recently added 'include media_features.h' to that header. So now
targets that include video_decoder_config need an explicit dependency
on media_features target, to ensure media_features.h is generated and
can be included by those targets.

BUG=606829
TBR=miu,wolenetz
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Committed: https://crrev.com/6e77ec93bfb9b3e913bf5b980a9fea02ada20e7e
Cr-Commit-Position: refs/heads/master@{#389821}

[servolk, 2016-04-26 17:34:59]

Description was changed from

==========
Added media_features dependency for cast_sender target

The cast_sender target ends up including video_decoder_config.h, and
I've recently added 'include media_features.h' to that header. So now
targets that include video_decoder_config need an explicit dependency
on media_features target, to ensure media_features.h is generated and
can be included by those targets.

BUG=606829
==========

to

==========
Added media_features dependency for cast_sender target

The cast_sender target ends up including video_decoder_config.h, and
I've recently added 'include media_features.h' to that header. So now
targets that include video_decoder_config need an explicit dependency
on media_features target, to ensure media_features.h is generated and
can be included by those targets.

BUG=606829
==========

[servolk, 2016-04-26 17:35:00]

servolk@chromium.org changed reviewers:
+ miu@chromium.org, wolenetz@chromium.org

[Charlie Reis, 2016-04-26 18:18:04]

Description was changed from

==========
Added media_features dependency for cast_sender target

The cast_sender target ends up including video_decoder_config.h, and
I've recently added 'include media_features.h' to that header. So now
targets that include video_decoder_config need an explicit dependency
on media_features target, to ensure media_features.h is generated and
can be included by those targets.

BUG=606829
==========

to

==========
Added media_features dependency for cast_sender target

The cast_sender target ends up including video_decoder_config.h, and
I've recently added 'include media_features.h' to that header. So now
targets that include video_decoder_config need an explicit dependency
on media_features target, to ensure media_features.h is generated and
can be included by those targets.

BUG=606829
TBR=miu,wolenetz
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
==========

[Charlie Reis, 2016-04-26 18:18:47]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2016-04-26 18:18:48]

Rubber stamp LGTM as sheriff to get the tree open; TBR'ing miu and wolenetz.

[Charlie Reis, 2016-04-26 18:18:54]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:19:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919163003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919163003/1

[commit-bot: I haz the power, 2016-04-26 18:19:50]

Description was changed from

==========
Added media_features dependency for cast_sender target

The cast_sender target ends up including video_decoder_config.h, and
I've recently added 'include media_features.h' to that header. So now
targets that include video_decoder_config need an explicit dependency
on media_features target, to ensure media_features.h is generated and
can be included by those targets.

BUG=606829
TBR=miu,wolenetz
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
==========

to

==========
Added media_features dependency for cast_sender target

The cast_sender target ends up including video_decoder_config.h, and
I've recently added 'include media_features.h' to that header. So now
targets that include video_decoder_config need an explicit dependency
on media_features target, to ensure media_features.h is generated and
can be included by those targets.

BUG=606829
TBR=miu,wolenetz
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
==========

[commit-bot: I haz the power, 2016-04-26 18:19:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-26 18:22:17]

Description was changed from

==========
Added media_features dependency for cast_sender target

The cast_sender target ends up including video_decoder_config.h, and
I've recently added 'include media_features.h' to that header. So now
targets that include video_decoder_config need an explicit dependency
on media_features target, to ensure media_features.h is generated and
can be included by those targets.

BUG=606829
TBR=miu,wolenetz
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
==========

to

==========
Added media_features dependency for cast_sender target

The cast_sender target ends up including video_decoder_config.h, and
I've recently added 'include media_features.h' to that header. So now
targets that include video_decoder_config need an explicit dependency
on media_features target, to ensure media_features.h is generated and
can be included by those targets.

BUG=606829
TBR=miu,wolenetz
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Committed: https://crrev.com/6e77ec93bfb9b3e913bf5b980a9fea02ada20e7e
Cr-Commit-Position: refs/heads/master@{#389821}
==========

[commit-bot: I haz the power, 2016-04-26 18:22:19]

Patchset 1 (id:??) landed as
https://crrev.com/6e77ec93bfb9b3e913bf5b980a9fea02ada20e7e
Cr-Commit-Position: refs/heads/master@{#389821}

[wolenetz, 2016-04-26 20:47:15]

On 2016/04/26 18:22:19, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/6e77ec93bfb9b3e913bf5b980a9fea02ada20e7e
> Cr-Commit-Position: refs/heads/master@{#389821}

LGTM though miu@ should take a look (I'm not an OWNER in media/cast).

[miu, 2016-05-02 23:49:18]

On 2016/04/26 20:47:15, wolenetz wrote:
> On 2016/04/26 18:22:19, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/6e77ec93bfb9b3e913bf5b980a9fea02ada20e7e
> > Cr-Commit-Position: refs/heads/master@{#389821}
> 
> LGTM though miu@ should take a look (I'm not an OWNER in media/cast).

Wait. What? I can't find anything under media/cast that references a
video_decoder_config.h file. Unless you're talking about this:

 sender/h264_vt_encoder_unittest.cc:#include
"media/filters/ffmpeg_video_decoder.h"

Please clarify. Otherwise the build file changes don't make sense.

[miu, 2016-05-02 23:50:58]

On 2016/05/02 23:49:18, miu wrote:
> On 2016/04/26 20:47:15, wolenetz wrote:
> > On 2016/04/26 18:22:19, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/6e77ec93bfb9b3e913bf5b980a9fea02ada20e7e
> > > Cr-Commit-Position: refs/heads/master@{#389821}
> > 
> > LGTM though miu@ should take a look (I'm not an OWNER in media/cast).
> 
> Wait. What? I can't find anything under media/cast that references a
> video_decoder_config.h file. Unless you're talking about this:
> 
>  sender/h264_vt_encoder_unittest.cc:#include
> "media/filters/ffmpeg_video_decoder.h"
> 
> Please clarify. Otherwise the build file changes don't make sense.

OIC. According to the crbug, it's an indirect dependency. So, doesn't that mean
the DEPS in the build files for media/video/video_encode_accelerator.h should be
fixed instead?