Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1919143005: Fix InlineTextBox::characterWidths() not to measure every substring (Closed)

Created:
4 years, 7 months ago by kojii
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Fix InlineTextBox::characterWidths() not to measure every substring This patch changes InlineTextBox::characterWidths() to use Font::individualCharacterRanges() rather than to measure every substring of InlineTextBox. Measuring every substring without context is very expensive and also is not correct. When dev tools have long strings without spaces such as minified JS and accessbility is turned on, the measuring of substrings can almost hang it up. Currently, WebAXObject::characterOffsets() is the only user of this function. BUG=593679, 568032 TEST=Existing tests cover, such as AutomationApiTest.BoundsForRange Review URL: https://codereview.chromium.org/1897853004 Cr-Commit-Position: refs/heads/master@{#388162} (cherry picked from commit 11f1c680cca2250e01121b9bddd7bc6f8fb28a96) Committed: https://chromium.googlesource.com/chromium/src/+/a3b71a920f64013793487faebeadc648c1a0774b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
kojii
Committed patchset #1 (id:1) manually as a3b71a920f64013793487faebeadc648c1a0774b.
4 years, 7 months ago (2016-04-27 18:16:47 UTC) #2
Justin Donnelly
4 years, 7 months ago (2016-04-27 19:28:56 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1927703002/ by jdonnelly@chromium.org.

The reason for reverting is: Broke the mac stable builder:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/m...

-----

Log output copied here for convenience:

../../third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp:33:10: fatal
error: 'platform/fonts/CharacterRange.h' file not found
#include "platform/fonts/CharacterRange.h"
         ^
1 error generated.
ninja: build stopped: subcommand failed..

Powered by Google App Engine
This is Rietveld 408576698