Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1919143004: Renaming cleanup of Promises (Closed)

Created:
4 years, 8 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni, Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Renaming cleanup of Promises The Promise code previously used many names which were gratuitiously different from the specification. This patch swaps in names from the ES2015 spec, and inserts crossreferences to the spec. The patch leaves mirrors over Promises unchanged for now, as these changes could have compatibility risk. R=cbruni@chromium.org Committed: https://crrev.com/d8967c55641483f5520fc25f0213691d4fa40786 Cr-Commit-Position: refs/heads/master@{#35962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -74 lines) Patch
M src/debug/mirrors.js View 4 chunks +5 lines, -5 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/js/prologue.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/js/promise.js View 17 chunks +90 lines, -54 lines 0 comments Download
M src/js/promise-extra.js View 1 chunk +4 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919143004/1
4 years, 8 months ago (2016-04-27 03:36:36 UTC) #2
Dan Ehrenberg
Camillo, this isn't everything you asked for in your review of https://codereview.chromium.org/1538663002 , but it's ...
4 years, 8 months ago (2016-04-27 03:40:30 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-27 04:01:41 UTC) #5
Camillo Bruni
nice! lgtm
4 years, 7 months ago (2016-04-27 12:39:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919143004/1
4 years, 7 months ago (2016-04-27 14:00:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14230)
4 years, 7 months ago (2016-04-27 14:04:38 UTC) #10
Dan Ehrenberg
Yang, you are an owner of src/debug. Could you take a look, as this patch ...
4 years, 7 months ago (2016-04-27 14:17:39 UTC) #12
Dan Ehrenberg
On 2016/04/27 at 14:17:39, Dan Ehrenberg wrote: > Yang, you are an owner of src/debug. ...
4 years, 7 months ago (2016-05-02 21:34:39 UTC) #13
Yang
src/debug lgtm
4 years, 7 months ago (2016-05-03 04:03:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919143004/1
4 years, 7 months ago (2016-05-03 06:52:18 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 07:19:19 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 07:21:20 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8967c55641483f5520fc25f0213691d4fa40786
Cr-Commit-Position: refs/heads/master@{#35962}

Powered by Google App Engine
This is Rietveld 408576698