pkg/compiler/lib/src/js_emitter/metadata_collector.dart - Issue 1919143002: Store constant variable initializers in elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/metadata_collector.dart

Issue 1919143002: Store constant variable initializers in elements. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/metadata_collector.dart

diff --git a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart

index 0fc56db8a30a1123c1c38bcfb24f12cc73418bd1..cbc18bc227f151a6b35fee806fd34a40aa510f05 100644

--- a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart

+++ b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart

@@ -213,7 +213,7 @@ class MetadataCollector implements jsAst.TokenFinalizer {

(targetParameterMap == null) ? element : targetParameterMap[element];

ConstantValue constant = (parameter == null)

? null

- : _backend.constants.getConstantValueForVariable(parameter);

+ : _backend.constants.getConstantValue(parameter.constant);

jsAst.Expression expression = (constant == null)

? new jsAst.LiteralNull()

: _emitter.constantReference(constant);