Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1919133004: Change default window size on Windows. (Closed)

Created:
4 years, 7 months ago by Brian Osman
Modified:
4 years, 7 months ago
Reviewers:
bungeman-skia, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change default window size on Windows. The OS tends to pick a very large size if you let it. Instead, choose a smaller (fixed) window (matching what we currently use on Linux). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919133004 Committed: https://skia.googlesource.com/skia/+/3ec513632c29fe9003052b36f6bae5e0bf15d88c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/views/win/SkOSWindow_win.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Brian Osman
4 years, 7 months ago (2016-04-26 21:38:44 UTC) #3
bungeman-skia
lgtm
4 years, 7 months ago (2016-04-26 21:41:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919133004/1
4 years, 7 months ago (2016-04-26 23:33:31 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 23:51:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3ec513632c29fe9003052b36f6bae5e0bf15d88c

Powered by Google App Engine
This is Rietveld 408576698