Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1919133003: bin/fetch-skps: print instruction on error (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
herb_g, bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

bin/fetch-skps: print instruction on error NOTRY=true Committed: https://skia.googlesource.com/skia/+/298ab76f1a47932ff86d1f615b564b0155846ec6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M bin/fetch-skps View 2 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hal.canary
PTAL
4 years, 8 months ago (2016-04-26 15:54:10 UTC) #3
bungeman-skia
lgtm, though I admit I haven't followed the instructions myself.
4 years, 8 months ago (2016-04-26 16:00:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919133003/1
4 years, 8 months ago (2016-04-26 16:01:49 UTC) #8
herb_g
lgtm Thanks for doing this.
4 years, 8 months ago (2016-04-26 17:01:22 UTC) #9
hal.canary
On 2016/04/26 17:01:22, herb_g wrote: > lgtm > > Thanks for doing this. Shell scripting ...
4 years, 8 months ago (2016-04-26 17:02:13 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 19:38:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/298ab76f1a47932ff86d1f615b564b0155846ec6

Powered by Google App Engine
This is Rietveld 408576698