Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 191913002: scoped_ptr<DEVMODE[]> replaced with scoped_ptr<DEVMODE, base::FreeDeleter>. (Closed)

Created:
6 years, 9 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 9 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

scoped_ptr<DEVMODE[]> replaced with scoped_ptr<DEVMODE, base::FreeDeleter>. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256087

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -60 lines) Patch
M chrome/service/cloud_print/cdd_conversion_win.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cdd_conversion_win.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/print_backend_win.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M printing/backend/win_helper.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M printing/backend/win_helper.cc View 3 chunks +27 lines, -26 lines 0 comments Download
M printing/printing_context_win.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 9 months ago (2014-03-08 06:51:22 UTC) #1
Noam Samuel
lgtm
6 years, 9 months ago (2014-03-10 17:14:43 UTC) #2
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-10 17:14:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/191913002/20001
6 years, 9 months ago (2014-03-10 17:50:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 19:47:55 UTC) #5
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=157783
6 years, 9 months ago (2014-03-10 19:47:56 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-10 19:48:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/191913002/20001
6 years, 9 months ago (2014-03-10 19:54:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/191913002/20001
6 years, 9 months ago (2014-03-10 21:44:20 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-10 21:49:09 UTC) #10
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-10 21:51:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/191913002/20001
6 years, 9 months ago (2014-03-10 22:23:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/191913002/20001
6 years, 9 months ago (2014-03-10 23:41:49 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 00:49:52 UTC) #14
Message was sent while issue was closed. 
Change committed as 256087

Powered by Google App Engine
This is Rietveld 408576698