ui/gfx/render_text_harfbuzz.h - Issue 1919123002: RenderTextMac: Cache the SkTypeface on the TextRun [reland]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.h

Issue 1919123002: RenderTextMac: Cache the SkTypeface on the TextRun [reland] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes, and a test, but somewhat orthogonal Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text_harfbuzz.h

diff --git a/ui/gfx/render_text_harfbuzz.h b/ui/gfx/render_text_harfbuzz.h

index 18022ba70e82597f04c21972967b5f73802d2fab..38ee2b4f3c31465d04b1e69784d0d5e270af5163 100644

--- a/ui/gfx/render_text_harfbuzz.h

+++ b/ui/gfx/render_text_harfbuzz.h

@@ -74,7 +74,7 @@ struct GFX_EXPORT TextRunHarfBuzz {

size_t glyph_count;

Font font;

- skia::RefPtr<SkTypeface> skia_face;

+ sk_sp<SkTypeface> skia_face;

FontRenderParams render_params;

int font_size;

int baseline_offset;

« no previous file with comments | « ui/gfx/render_text.cc ('k') | ui/gfx/render_text_harfbuzz.cc » ('j') | no next file with comments »